search

inloop / easygcm

Android Library for easy GCM integration in few lines of code.
Apache License 2.0
261 stars 43 forks source link

Update gcm3 #38

Closed peterbartos closed 9 years ago

peterbartos commented 9 years ago

Update to new GCM using Play Services 7.5. Fix #36 #34 #33 #32

DanielNovak commented 9 years ago

I will take a look at this. Adding also @destil to this PR.

DanielNovak commented 9 years ago

Back to you, @peterbartos .

davidvavra commented 9 years ago

Isn't the google-services.json file with configuration required? Even if it's not, I think it's a nice way how to configure Google APIs. Nothing in resources (config.xml), just one json in the app. And I imagine that the app will need multiple Google APIs, then the app needs just one json for all APIs (login, Drive, GCM, ...) and it will just work.

DanielNovak commented 9 years ago

+1 on the json configuration files. To keep backwards compatibility we can check if easygcm_sender_id string and only use it in that case. Otherwise the json file will be used. The developers will be instructed by the README to put apply plugin: 'com.google.gms.google-services into their build.gradle files.

DanielNovak commented 9 years ago

I am OK with this. The AsyncTask can be converted to an wakeful IntentService in a separate pull request. @destil do you see any more issues here? Thanks.

peterbartos commented 9 years ago

Thank you @destil for the good review. Good idea with adding the string only as a value without using the plugin. Update soon...

davidvavra commented 9 years ago

Code-review +2, Looks good to me

DanielNovak commented 9 years ago

Okay, this is ready to merge @peterbartos .