search

inloop / easygcm

Android Library for easy GCM integration in few lines of code.
Apache License 2.0
261 stars 43 forks source link

Merging with latest Google GCM sample? #40

Closed martinadamek closed 9 years ago

martinadamek commented 9 years ago

Originally this project was based on GCM sample from Google. There is now updated sample at https://developers.google.com/cloud-messaging/android/start with git repo https://github.com/googlesamples/google-services.git

It is using classes like GcmListenerService that we do not. Would that help us to remove parts of the code and keep everything cleaner?

martinadamek commented 9 years ago

Cc @DanielNovak @destil @peterbartos

DanielNovak commented 9 years ago

We are actually extending GcmListenerService https://github.com/inloop/easygcm/blob/master/easygcm/src/main/java/eu/inloop/easygcm/EasyGcmListenerService.java

martinadamek commented 9 years ago

Oops, wrong search filter in my editor :-) Does that mean we also looked at current sample and picked some useful stuff (if any)?

peterbartos commented 9 years ago

hi @martinadamek, yes we ckecked the current sample :) for example also the new InstanceIDListenerService was included in easygcm. If you find some more useful things, that would be nice!

DanielNovak commented 9 years ago

Yes, I think we took almost everything that was useful. The only thing missing is an IntentService instead of an AsyncTask for the server registration task, there is also an issue created for this.

martinadamek commented 9 years ago

Cool! Closed and created #41 for AsyncTask -> IntentService migration.