inmagik / ionic-modal-select

Modal select for Ionic Framework
https://inmagik.github.io/ionic-modal-select
MIT License
174 stars 70 forks source link

Add option to hide-footer #77

Open ichagas opened 8 years ago

ichagas commented 8 years ago

First, thank you for this module, it is simple and useful.

I made some personal adjustments that I would love to share and make it available in the main repo.

In order to make a simpler UI interaction I added the option hide-footer which can be true or (the standard) false.

Adding this option you create 2 scenarios:

Scenario 1: With Search Bar Turned On On this scenario:

See the example captura de tela 2016-11-01 as 11 37 59

Scenario 2: Without Search Bar On this scenario:

See the example captura de tela 2016-11-01 as 11 43 57

I only tested the simple selection modal, the multi must be tested but I believe it is save to say it is OK since the changes are minimal.

Regards

bianchimro commented 8 years ago

hi @ichagas and thanks for your work! I'm going to review your contributions ASAP, this is a nice feature indeed.

best regards Mauro

ichagas commented 8 years ago

Great!

I've just made some additional adjustments and perhaps inside the input field the icon ion-close-round looks better than ion-android-close that I picked earlier.