inmanta / aws

Moved to https://code.inmanta.com/solutions/modules/aws

0 stars 0 forks source link

[FIX] remove reviewer checklist #830

Closed Hugo-Inmanta closed 1 year ago

Hugo-Inmanta commented 1 year ago

Description

remove reviewer checklist

part of https://github.com/inmanta/inmanta-core/issues/5005

Merge procedure

Don't use the github built-in merge, but the process described here

git pull
git checkout master
git pull
git merge --squash issue/{issue-number}-{short description}
inmanta module commit -m "{Commit Message Here}" -r
git push
git push {tag} # push the tag as well

Then close the PR with a reference to the commit

Self Check:

Strike through any lines that are not applicable (~~line~~) then check the box

[ ] Attached issue to pull request
[ ] Changelog entry
[ ] Version number is bumped to dev version
[ ] Code is clear and sufficiently documented
[ ] Sufficient test cases (reproduces the bug/tests the requested feature)
[ ] Correct, in line with design
[ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )

Reviewer Checklist:

[ ] Sufficient test cases (reproduces the bug/tests the requested feature)
[ ] Code is clear and sufficiently documented
[ ] Correct, in line with design