inmanta / inmanta-core

Inmanta is an automation and orchestration tool
https://inmanta.com
Apache License 2.0
27 stars 7 forks source link

Issue/8052 make get or else backward compatible #8143

Closed Hugo-Inmanta closed 2 hours ago

Hugo-Inmanta commented 2 days ago

Description

Follow-up to https://github.com/inmanta/inmanta-core/pull/8109/files#diff-ad2bbfb0ef3fc86910ef80ee69791b16f3b8c78491912c25f3edaa3a651deb43

The previous implementation didn't take into account the necessity for the get_or_else method to be backwards compatible wrt the for_version and timeout arguments.

Slack discussion: https://inmanta.slack.com/archives/CKRF0C8R3/p1727851998216269

Self Check:

Strike through any lines that are not applicable (~~line~~) then check the box

- [ ] Attached issue to pull request

inmantaci commented 2 hours ago

Processing this pull request

inmantaci commented 2 hours ago

Merged into branches master in e15a8b3c51e466ad7d7a1a456c9e321529b67ae0