inmanta / inmanta-sphinx

Sphinx domains for Inmanta docs

0 stars 0 forks source link

issue/4984-remove get_entity() call #58

Closed FloLey closed 1 year ago

FloLey commented 1 year ago

Description

remove get_entity() call. related to https://github.com/inmanta/inmanta-core/pull/5120 closes https://github.com/inmanta/inmanta-core/issues/4984

Self Check:

Strike through any lines that are not applicable (~~line~~) then check the box

[x] Attached issue to pull request
[x] Changelog entry
[x] Code is clear and sufficiently documented
[x] Correct, in line with design
[ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )

Reviewer Checklist:

[ ] Code is clear and sufficiently documented
[ ] Correct, in line with design

FloLey commented 1 year ago

I didn't know this was used here. Technically, default constructors could still be used for iso4/5 models and this would break compatibility. I would suggest keeping the method in core for backwards compatibility and dropping this PR. @wouterdb wdyt?

repinging @wouterdb