inngest / inngest-js

The developer platform for easily building reliable workflows with zero infrastructure for TypeScript & JavaScript
https://www.inngest.com/
GNU General Public License v3.0
414 stars 41 forks source link

Fix `"inngest/next"` types not inferring from `defineProperties` #348

Closed jpwilliams closed 12 months ago

jpwilliams commented 12 months ago

Summary

Fixes #340, ensuring the return type of "inngest/next"'s serve() is correctly inferred.

Fuller integration tests for the app router will come in #341.

Checklist

Related

changeset-bot[bot] commented 12 months ago

🦋 Changeset detected

Latest commit: edfad191812c0dc0e057535f6e7fec93cbdbc428

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------- | ----- | | inngest | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

jpwilliams commented 12 months ago

@djfarrelly: LGTM - Weird typescript stuff on this one!

Yeah. v2 got away with this because we always returned any. #341 adds integration tests for the app router which will catch this in the future.