inngest / inngest-js

The developer platform for easily building reliable workflows with zero infrastructure for TypeScript & JavaScript
https://www.inngest.com/
GNU General Public License v3.0
440 stars 43 forks source link

Simplify step returns such that `JsonifyObject<>` is hidden entirely #371

Closed jpwilliams closed 1 year ago

jpwilliams commented 1 year ago

Summary

Step results are serialized and deserialized while being pushed to/from Inngest, so step returns are typed as JSON to make this clear.

These returns still came back wrapped in JsonifyObject<>, though, meaning they didn't actually show the resulting changes unless the user started to attempt to use them. This small change ensures we display the resulting type correctly, free of any wrappers.

image image
Before After

Checklist

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 4746da666a76169875a70bec39f7860795c13797

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------- | ----- | | inngest | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

inngest-release-bot commented 1 year ago

A user has added the prerelease/inngest label, so this PR will be published to npm with the tag pr-371. It will be updated with the latest changes as you push commits to this PR.

You can install this prerelease version with:

npm install inngest@pr-371

The last release was built and published from 4746da666a76169875a70bec39f7860795c13797.