Closed jpwilliams closed 11 months ago
Latest commit: 450b5612f417e97b6b0cfc5bc9f3102b4dde015b
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
[Click here if you're a maintainer who wants to add another changeset to this PR](https://github.com/inngest/inngest-js/new/fix/strip-bigint?filename=.changeset/moody-beans-teach.md&value=---%0A%22inngest%22%3A%20patch%0A---%0A%0AFix%20%60stringify()%60%20failing%20to%20serialize%20%60BigInt%60%3B%20remove%20instead%0A)
Add to tests:
BigInt
type check
Summary
BigInt
s are not natively parsed by JSON. Attempting to return aBigInt
from a step or function will throw an error. This error was hard to see, which is fixed in #374.Our types reflect that
BigInt
is unparseable and will type it asnever
, though these were obscured from the user a touch, which is fixed in #371.For this reason, this PR ensures
BigInt
s are removed during parsing instead of throwing. We can investigate addingBigInt
support across our SDKs past this fix; then
suffix seems an unwritten standard.Checklist
Added a docs PR that references this PRN/ARelated
371
374