Remove prod check to enable integration tests with dev server - Githubissues

inngest / inngest-js

The developer platform for easily building reliable workflows with zero infrastructure for TypeScript & JavaScript

https://www.inngest.com/

GNU General Public License v3.0

414 stars 41 forks source link

Remove prod check to enable integration tests with dev server #424

Closed djfarrelly closed 7 months ago

djfarrelly commented 9 months ago

Summary

Developers sometimes run production builds against the dev server for integration testing. This skips the prod check which may produce a false positive where the signing key would be required. Requests are not signed in the dev server.

Checklist

[ ] Added a docs PR that references this PR
[ ] Added unit/integration tests
[ ] Added changesets if applicable

Related

Discord discussion

changeset-bot[bot] commented 9 months ago

⚠️ No Changeset found

Latest commit: de9cab3701ba340695f098326a803fe540fd0612

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

jpwilliams commented 7 months ago

Superseded by #488.