inngest / inngest-js

The developer platform for easily building reliable workflows with zero infrastructure for TypeScript & JavaScript
https://www.inngest.com/
GNU General Public License v3.0
440 stars 43 forks source link

Ensure workspace linking is defined globally otherwise it's inconsistent #431

Closed jpwilliams closed 11 months ago

jpwilliams commented 11 months ago

Summary

Sets the link-workspace-packages setting to false, meaning internal linking between packages is not attempted.

This is done to prevent an inngest peer dependency from using the unbuilt local package, as the build process for inngest is non-trivial and the location of the built files changes.

We move it here (from within the packages/middleware-encryption directory) so that this always takes effect when running pnpm install. Otherwise, the global pnpm-lock.yaml file will change depending on where you run pnpm install in the project, which is not good.

Checklist

changeset-bot[bot] commented 11 months ago

⚠️ No Changeset found

Latest commit: 2e7a26d96e99f20bc317d6159f221a863db0e9af

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR