search

inngest / inngest-js

The developer platform for easily building reliable workflows with zero infrastructure for TypeScript & JavaScript
https://www.inngest.com/
GNU General Public License v3.0
414 stars 41 forks source link

[BUG] @inngest/middleware-encryption doesn't work due to missing dist files #450

Closed jessethomson closed 9 months ago

jessethomson commented 9 months ago

Describe the bug The generated dist files are not included in the published package for the @inngest/middleware-encryption npm package.

To Reproduce Steps to reproduce the behavior:

Run the following commands in the terminal

  1. mkdir test-dir
  2. cd test-dir
  3. npm init -y
  4. npm i @inngest/middleware-encryption
  5. ls -la node_modules/@inngest/middleware-encryption

Expected behavior I expect to see dist/index.js and dist/index.d.ts files within the node_modules/@inngest/middleware-encryption folder

Code snippets / Logs / Screenshots

Local Screenshot

Screenshot 2024-01-03 at 8 56 10 PM

Unpkg URL

https://unpkg.com/@inngest/middleware-encryption@0.1.2/dist/index.js

System info (please complete the following information):

Additional context I git cloned the inngest-js repo, ran pnpm install, and then pnpm run build, and everything seems to be generated in the dist folder correctly, so my guess is something wrong with the CI or publishing scripts?

jessethomson commented 9 months ago

Of course as soon as I create this issue, I find the answer 🤦

It looks like the issue was already fixed by this PR, but a changeset still needs to be added for the @inngest/middleware-encryption package, and then it needs to be released.

jessethomson commented 9 months ago

I created a quick PR to fix this, but I also realize:

1) it's so simple it might be easier to do it yourselves 2) You may have conventions I'm not aware of and teaching me isn't a priority (also, see point 1 above) 3) You may not be accepting open source contributions at this time

Anyway, feel free to merge or close according to your preference!

jpwilliams commented 9 months ago

Nope, this is perfect, @jessethomson - thanks! I didn't make the connection that this'd be affecting @inngest/middleware-encryption too. 🙂

Should be resolved now in @inngest/middleware-encryption@0.1.3.

jessethomson commented 9 months ago

Everything looks good in @inngest/middleware-encryption@0.1.3!

I was able to install it, set it up, and deploy to production and everything seems to be working as advertised! Thanks!