inngest / inngest-js

The developer platform for easily building reliable workflows with zero infrastructure for TypeScript & JavaScript
https://www.inngest.com/
GNU General Public License v3.0
414 stars 41 forks source link

Add step name or ID when there’s a NESTING_STEPS error #549

Closed maktouch closed 5 months ago

maktouch commented 5 months ago

Summary

When there's a NESTING_STEPS error, debugging it is tricky because the stack traces can't necessarily determine the correct faulty file.

Checklist

- [ ] Added a docs PR that references this PR N/A, this is augmenting an existing error - [ ] Added unit/integration tests N/A, I don't think it's worth it - [ ] Added changesets if applicable N/A, I don't think it's worth it.

Related

changeset-bot[bot] commented 5 months ago

🦋 Changeset detected

Latest commit: c984869fa63723969c4a02c72ee6ccbc16cd090f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------- | ----- | | inngest | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

jpwilliams commented 5 months ago

This is great, @maktouch! Thanks for the contribution.

In terms of the original issue (#546) and not being able to see which step is causing the problem, would #531 also be a part of helping with this?

Basically, is the current stack trace useless as it's mostly listing calls internal to this library?

maktouch commented 5 months ago

Ideally, I think better stack traces are the way to go, so #531 makes sense.

This is how it currently looks

CleanShot 2024-04-22 at 12 47 33