Make DefaultEncryptionService use libsodium

inngest / inngest-js

The developer platform for easily building reliable workflows with zero infrastructure for TypeScript & JavaScript

https://www.inngest.com/

GNU General Public License v3.0

414 stars 41 forks source link

Make DefaultEncryptionService use libsodium #555

Closed goodoldneon closed 2 months ago

goodoldneon commented 5 months ago

Summary

Change DefaultEncryptionService in @inngest/middleware-encryption to use libsodium. This is a breaking change.

Standardizing our SDKs' encryption middlewares on libsodium allows for easy interoperability. For example, our TypeScript SDK could send an encrypted event to our Python SDK.

Todo

[x] Make two middleware for proper support 🫠
[x] Async encrypt/decrypt

Checklist

[ ] ~Added a docs PR that references this PR~ N/A Documented in-package
[x] Added unit/integration tests
[x] Added changesets if applicable

changeset-bot[bot] commented 5 months ago

🦋 Changeset detected

Latest commit: 44b1ab6b70d716ad6e339630776c773e60a7410c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | ------------------------------ | ----- | | @inngest/middleware-encryption | Major |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

jpwilliams commented 3 months ago

https://github.com/inngest/inngest-js/blob/80e45b52c045e8e4d96a3290cf2c5bb886b53e8a/packages/middleware-encryption/MIGRATION.md#L1-L66

jpwilliams commented 2 months ago

[!WARNING] Holding merge until Python is also ready.

inngest-release-bot commented 2 months ago

A user has added the prerelease/inngest label, so this PR will be published to npm with the tag pr-555. It will be updated with the latest changes as you push commits to this PR.

You can install this prerelease version with:

npm install inngest@pr-555

The last release was built and published from 17e7107d90eb7dc48046b1ac235a4c0e26e690f3.

inngest-release-bot commented 2 months ago

A user has added the prerelease/middleware-encryption label, so this PR will be published to npm with the tag pr-555. It will be updated with the latest changes as you push commits to this PR.

You can install this prerelease version with:

npm install @inngest/middleware-encryption@pr-555

The last release was built and published from 44b1ab6b70d716ad6e339630776c773e60a7410c.