Fix `"inngest/hono"` serve handler not parsing environment variables - Githubissues

inngest / inngest-js

The developer platform for easily building reliable workflows with zero infrastructure for TypeScript & JavaScript

https://www.inngest.com/

GNU General Public License v3.0

414 stars 41 forks source link

Fix `"inngest/hono"` serve handler not parsing environment variables #571

Closed jpwilliams closed 4 months ago

jpwilliams commented 4 months ago

Summary

The "inngest/hono" serve handler was not fetching environment variables, which are not reliably accessible via globals in common environments such as Cloudflare Workers.

In addition, url handling was a little wonky and didn't seem to handle many variants. The hope was that Hono handled that to ensure that c.req.url is always/never absolute, but this doesn't seem to be the case.

Checklist

[ ] ~Added a docs PR that references this PR~ N/A
[ ] ~Added unit/integration tests~ N/A
[x] Added changesets if applicable

Related

Supersedes #557 as we should no longer be required to manually set signing and event keys
Fixes #560's URL issues
Fixes some of the isues in #556, though there are still some unknowns for the C++ errors there

changeset-bot[bot] commented 4 months ago

🦋 Changeset detected

Latest commit: f1d8ad8374e97330961a0d307b19d9646f7607d6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | ------- | ----- | | inngest | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

inngest-release-bot commented 4 months ago

A user has added the prerelease/inngest label, so this PR will be published to npm with the tag pr-571. It will be updated with the latest changes as you push commits to this PR.

You can install this prerelease version with:

npm install inngest@pr-571

The last release was built and published from f1d8ad8374e97330961a0d307b19d9646f7607d6.