inngest / inngest-js

The developer platform for easily building reliable workflows with zero infrastructure for TypeScript & JavaScript
https://www.inngest.com/
GNU General Public License v3.0
370 stars 37 forks source link

Fix broken `debug` extension #631

Closed jpwilliams closed 3 days ago

jpwilliams commented 3 days ago

Summary

debug is a really old library, and its browser detection is old, too. For newer pairings of framework and runtime such as Nitro + Cloudflare Pages, their code for detecting which code should be delivered doesn't catch the markers these leave behind.

One silly symptom of this is that Debug() returns an anonymous function with no extra properties instead of a Debugger instance if the wrong code is consumed following a bad detection. This results in the following .extend() call failing.

We fix that here by just not calling .extend().

Checklist

changeset-bot[bot] commented 3 days ago

🦋 Changeset detected

Latest commit: 87a378cb1fdec14dd2c474a01184d3c892e3132f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------- | ----- | | inngest | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

inngest-release-bot commented 3 days ago

A user has added the prerelease/inngest label, so this PR will be published to npm with the tag pr-631. It will be updated with the latest changes as you push commits to this PR.

You can install this prerelease version with:

npm install inngest@pr-631

The last release was built and published from 87a378cb1fdec14dd2c474a01184d3c892e3132f.