If response signing fails when successfully validated req, throw

inngest / inngest-js

The developer platform for easily building reliable workflows with zero infrastructure for TypeScript & JavaScript

https://www.inngest.com/

GNU General Public License v3.0

440 stars 43 forks source link

If response signing fails when successfully validated req, throw #737

Closed jpwilliams closed 2 weeks ago

jpwilliams commented 2 weeks ago

Summary

If the request is signed, we expect that the response will also be signed. This PR ensures that if signing the response fails, we throw a 500 Internal Server Error instead of silently failing.

This is to address issues where trust probes are performed but the response is not signed.

Checklist

[ ] ~Added a docs PR that references this PR~ N/A Internal
[x] Added unit/integration tests
[x] Added changesets if applicable

changeset-bot[bot] commented 2 weeks ago

🦋 Changeset detected

Latest commit: 0278d3e73272f5f0d031e9f6545f01a167910c0a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | ------- | ----- | | inngest | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR