inngest / inngest-py

Python SDK for Inngest: Durable functions and workflows in Python, hosted anywhere
https://www.inngest.com/docs/reference/python
Apache License 2.0
27 stars 6 forks source link

Support Python 3.9 #65

Closed goodoldneon closed 6 months ago

goodoldneon commented 6 months ago

Description

Add Python 3.9 support. This required 2 changes:

Additionally:

Issue

61

Review

This PR has a lot of changes but they're very low risk since they're almost entirely type annotations. We have a thorough test suite, so these changes should be OK as long as everything passes

jpwilliams commented 6 months ago

@goodoldneon Can user code can still use the newer features like the | operator even though the types are created using typing.Union?

Also we should update the badge on the README to show 3.9 and maybe supported version ranges of the frameworks too?

goodoldneon commented 6 months ago

Can user code can still use the newer features like the | operator even though the types are created using typing.Union?

Yes, type checkers treat typing.Union the same way as |, so users are free to continue using | in their code.

Also we should update the badge on the README to show 3.9 and maybe supported version ranges of the frameworks too?

The badge will automatically update when we publish next. I added framework versions to the readme