search

inngest / inngest-py

Python SDK for Inngest: Durable functions and workflows in Python, hosted anywhere
https://www.inngest.com/docs/reference/python
Apache License 2.0
27 stars 6 forks source link

Consolidate step.invoke logic #71

Closed goodoldneon closed 5 months ago

goodoldneon commented 5 months ago

Since step.invoke and step.invoke_by_id do literally the same thing but with a different function signature, they should share the same logic.

I also renamed FunctionOpts.id to FunctionOpts.fully_qualified_id to make its purpose more obvious. Added FunctionOpts.local_id since this was necessary for accessing the local ID within step.invoke

goodoldneon commented 5 months ago

Is removing id a break? Minor bump?

It's internal only. We don't export FunctionOpts and we assign its object to a private field (_opts)