Reject filters not ending in :d

innix / shrek

A vanity .onion address generator written in Go.

MIT License

16 stars 0 forks source link

Reject filters not ending in :d #2

Closed da2x closed 2 years ago

da2x commented 2 years ago

d must be the last character in an v3 address. The CLI should warn and reject filters for :end that doesn’t end with d.

innix commented 2 years ago

You are right, thanks for raising this issue.

It's also true that the 2nd last character in a v3 address must be one of these characters: a, i, q, y. So for example, every valid v3 address will have one of these endings:

ad.onion
id.onion
qd.onion
yd.onion

The filter validation function is very basic, it could definitely do with some improvements:

https://github.com/innix/shrek/blob/0d771d3381b28904c2da63ce2bea38ea09eb7127/cmd/shrek/main.go#L222-L224

innix commented 2 years ago

This has been fixed as part of the v0.6.1 release (76baa6a86c8eb5e39ad4ea68eeb4b7efa044d3a1).