Closed DanceMore closed 7 months ago
@DanceMore thanks for the contribution. Your change is correct, but missed updating generated/packages/kubectl.yaml
.
I updated your PR to fix that. Next time, please remember to run make generate
to update the package manifests in the generated
folder.
look at that, it's even documented well enough that I should have been able to figure it out => https://github.com/innobead/huber#contribution
definitely my bad for not reading all the way to the bottom. I got a little too focused on finding the fix and seeing if upstream was interested.
I'm loving huber
because I'm often installing the same tools on Linux as well as both older and newer Macbooks. all my work-provided laptops over the last 3 years have been Apple Silicon, so it's here to stay, and I'm willing to spend some of my own time making sure tools and FOSS I value are actually available for all the ARM users.
I appreciate that you ran the make
and approved all the changes. I probably would have used git add -p
to select only the kubectl
changes and skipped the handful of subtle description changes in binaries I was not targeting.
referenced the "Apple Silicon" tab here:
https://kubernetes.io/docs/tasks/tools/install-kubectl-macos/#install-kubectl-binary-with-curl-on-macos
the
generated/
files say to not modify them, so I found the generator and modified it instead. I don't know how it gets run and checked back in.all the patch does is adds the
PackageTargetType::MacOSArm64
and changes the URL to hitdarwin/arm64
instead ofdarwin/amd64
.let me know if there's more required. I might be interested in adding mac-arm64 to more packages too.