search

innoq / iqvoc

iQvoc - A SKOS(-XL) Vocabulary Management System for the Semantic Web
http://iqvoc.net/
Other
117 stars 44 forks source link

Duplicate collection assignment on new concept #358

Closed metaweidner closed 7 years ago

metaweidner commented 7 years ago

I am encountering a situation when creating new concepts where a concept is assigned to the same collection multiple times on save. It seems to happen when a Collection and a Concept Mapping are added at the same time. The same collection label appears multiple times on the record after it has been saved. I can either add a Collection and save or add a Concept Mapping and save, but not both at the same time.

metaweidner commented 7 years ago

Just saw this commit: 21e51b0 We'll update and see if it fixes the issue.

metaweidner commented 7 years ago

We noticed that the 4.10 gem version was released well before the commit to fix the duplicate collection assignment. When do you anticipate a 4.11 release that incorporates this fix?

mjansing commented 7 years ago

I pushed v4.11.0 to Rubygems. Let us know if there are any further issues. Thanks for using iQvoc.

seanlw commented 7 years ago

@mjansing, I work with @metaweidner and I've been able to replicate the problem under the v4.11 gem. I've provided some screenshots for the process described above. Again, the collection is duplicated only when a Match is added (1 or more). Let me know if you need anything if you can't reproduce.

Ruby: 2.2.4 Rails: 4.2.8 iQvoc: 4.11.0

Creating new concept and added "Test Collection" collection: screen shot 2017-03-23 at 11 09 22 am

Match added to concept: screen shot 2017-03-23 at 11 09 53 am

Result showing "Test Collection" added twice after concept is saved: screen shot 2017-03-23 at 11 10 01 am

seanlw commented 7 years ago

If you assign more than one collection, it will duplicate them all.

screen shot 2017-03-23 at 11 50 58 am

mjansing commented 7 years ago

Thanks for investigation. Yes it looks this is still an issue.

mjansing commented 7 years ago

Again, the collection is duplicated only when a Match is added

This is a good catch. I'll try to dig into this issue.

mjansing commented 7 years ago

@seanlw: I pushed 00c8f27 to deal with this issue. Would you like to test this. After that I'll push iQvoc 4.11.1 to Rubygems.

seanlw commented 7 years ago

@mjansing All my tests look good now and I don't see any duplications. Thank you for looking into this so quickly.

mjansing commented 7 years ago

Great. I pushed v4.11.1 to Rubygems.