search

innosat-mats / MATS-L1-processing

Python code for calibrating MATS images
MIT License
0 stars 1 forks source link

read_ccd_data_in_interval now uses partitioning for faster accessing #140

Closed OleMartinChristensen closed 1 year ago

OleMartinChristensen commented 1 year ago

Improves performance for slow internet connections. See issue #138

OleMartinChristensen commented 1 year ago

if it looks ok now can you approve @skymandr ?

OleMartinChristensen commented 1 year ago

I cannot get this to work with l1b data..?

skymandr commented 1 year ago

I cannot get this to work with l1b data..?

At a guess this is because the L1B-data in all current versions have a residual prefix in the form of the L1A-bucket from which it originates. This needs to be put in the path (or alternatively the prefix-attribute where applicable) explicitly. See the coverage script that I sent you for an example. Note that this prefix will be removed in future versions.

OleMartinChristensen commented 1 year ago

I cannot get this to work with l1b data..?

At a guess this is because the L1B-data in all current versions have a residual prefix in the form of the L1A-bucket from which it originates. This needs to be put in the path (or alternatively the prefix-attribute where applicable) explicitly. See the coverage script that I sent you for an example. Note that this prefix will be removed in future versions.

yes ill do a patch for this before we merge

skymandr commented 1 year ago

I cannot get this to work with l1b data..?

At a guess this is because the L1B-data in all current versions have a residual prefix in the form of the L1A-bucket from which it originates. This needs to be put in the path (or alternatively the prefix-attribute where applicable) explicitly. See the coverage script that I sent you for an example. Note that this prefix will be removed in future versions.

yes ill do a patch for this before we merge

I think that functionality might be better to have in Mats-utils than in this function to be fair.

OleMartinChristensen commented 1 year ago

I cannot get this to work with l1b data..?

At a guess this is because the L1B-data in all current versions have a residual prefix in the form of the L1A-bucket from which it originates. This needs to be put in the path (or alternatively the prefix-attribute where applicable) explicitly. See the coverage script that I sent you for an example. Note that this prefix will be removed in future versions.

yes ill do a patch for this before we merge

I think that functionality might be better to have in Mats-utils than in this function to be fair.

yes, agreed. I will add it there, just want to test it before mergning in this ;)