innovaccer / design-system

Masala Design System (MDS) is an open-source design system built at Innovaccer. Figma file : https://www.figma.com/community/file/974368355920553546/masala-design-system-web-guidelines
https://mds.innovaccer.com
MIT License
84 stars 79 forks source link

In dropdown, selected value is calling onChange when user clicked on the selected value #1557

Closed atifzaidi92 closed 1 year ago

atifzaidi92 commented 1 year ago

Description

Describe the issue that you're seeing. OnChange is called on clicking of the selected value in the dropdown

Steps to reproduce

  1. open the dropdown
  2. select some value
  3. open again the dropdown
  4. select same value again
  5. onChange is fired

Clear steps describing how to reproduce the issue.

Expected result

What should happen? if i clicked on the selected value, it should not call the onchange

Actual result

What happened. onchange is fired

veekays commented 1 year ago

This issue has been resolved. PR link:- https://github.com/innovaccer/design-system/pull/1563