innovaccer / design-system

Masala Design System (MDS) is an open-source design system built at Innovaccer. Figma file : https://www.figma.com/community/file/974368355920553546/masala-design-system-web-guidelines
https://mds.innovaccer.com
MIT License
84 stars 79 forks source link

Chip component height not consistent for all types. #924

Closed satyamyadav closed 2 years ago

satyamyadav commented 2 years ago

Description

The height and width of the Chip component is 2px more than type input in case of types action and selection. It seems that the border width is adding up in width and height and property box-sizing: border-box is not applied as it has display inline-flex.

Steps to reproduce

Expected result

Actual result

What happened.

Height and width is not consistent for all types of the Chip component.

AlithAnar commented 2 years ago

Hi, I think that the inline-flex property is not an issue here. The Chip component doesn't know how tu sum up the total width here because the element width is not static (width: fit-content currently). For action and selection Chips wouldn't outline property be a better choice? image

innosatyam commented 2 years ago

Closing due to inactivity.