innoveit / play2-pdf

A PDF module for Play Framework 2
MIT License
77 stars 22 forks source link

Use constructor injection instead of field injection #33

Closed eximius313 closed 5 years ago

eximius313 commented 5 years ago

PR for: https://github.com/innoveit/play2-pdf/issues/32 It's for 1.8.0 version because I need it now. It can be easily changed for 1.9.0

eximius313 commented 5 years ago

@marcosinigaglia sorry, I don't know how to set 1.8.1 correctly...

marcosinigaglia commented 5 years ago

Hi @eximius313 , can you make a PR in a new branch? I don't know if is it possible, alternatively I create a new branch for 1.8.0.

eximius313 commented 5 years ago

Please create 1.8 branch (from 1.8.0 tag) and I'll provide second PR

eximius313 commented 5 years ago

@marcosinigaglia - Done: https://github.com/innoveit/play2-pdf/pull/34