search

inocan-group / vue3-google-map

A set of composable components for easy use of Google Maps in your Vue 3 projects.
https://vue3-google-map.com
MIT License
280 stars 57 forks source link

Better custom control #39

Closed VitAndrGuid closed 3 years ago

VitAndrGuid commented 3 years ago

In my previous pull request i introduced a bug where custom controls would not show if they were added after the map was already loaded.

This happened because i waited for the map to load using a watcher and only when the map loaded it would show the content, but the watcher wasnt immediate so if the map and the api was already loaded it would'nt trigger the watcher callback thus the content would never be shown.

I also fixed some bugs: 1- Now if the custom control is destroyed it is properly removed from the map 2- Reacting to position changes wasnt working properly

netlify[bot] commented 3 years ago

Deploy request for vue3-google-map accepted.

Accepted with commit 160873c2fd0ac6d720c8f2e58d055cc207435129

https://app.netlify.com/sites/vue3-google-map/deploys/60a0c57cafe3950007c78b71

yankeeinlondon commented 3 years ago

I've published on npm as 0.7.10