search

inocan-group / vue3-google-map

A set of composable components for easy use of Google Maps in your Vue 3 projects.
https://vue3-google-map.com
MIT License
283 stars 57 forks source link

How to set `region` and `language` #7

Closed maninak closed 3 years ago

maninak commented 3 years ago

We're migrating to vue3 which means we're also migrating from vue2-google-maps to vue3-google-map (yay!)

In vue2-google-maps I could use a localized map (critical in our use case)

like so:

image

How would I achieve that with this library? I also had a quick look in the source code and it looks like there's no support for it?

Any chance that we can specify region and language when initializing google maps?

Thank you so much for publishing this library!

yankeeinlondon commented 3 years ago

Hi @maninak , I can see how that would be desirable to have. If I understand from your link to the localized map it would appear that this would just be a matter of proxying the config from the Vue component to the Google API. Correct? If so the level of effort is probably pretty simple. I personally am completely swamped but @HusamIbrahim may have time to look at this. Alternatively, if you felt up to it we'd happily accept a PR.

JoseGoncalves commented 3 years ago

Just added 2 PRs to support map localization; https://github.com/inocan-group/connect-google-maps/pull/1 & https://github.com/inocan-group/vue3-google-map/pull/8

maninak commented 3 years ago

Thank you @JoseGoncalves and @ksnyde for the the support and swift follow-up!

I'm currently on vacation but I'll let the team know the new new version coming with the new features.

Also thank you for packaging up this nice wrapper for the community so that the rest of us don't have to. 👏

HusamElbashir commented 3 years ago

This landed in v0.5.0. You can now set the region and language props on the GoogleMap component.