Fix ESM-CJS compatibility (#36)

inokawa / remark-docx

remark plugin to compile markdown to docx (Microsoft Word, Office Open XML).

https://inokawa.github.io/remark-docx/

MIT License

42 stars 15 forks source link

Fix ESM-CJS compatibility (#36) #37

Closed zetlen closed 1 year ago

zetlen commented 1 year ago

Resolves #36.

Updates docx version to 8.1.0, which uses package.json exports correctly and supports direct ESM import
Updates unist-util-visit to current release
Uses the modern package.json exports field to conditionally export for module formats
Removes reliance on unstable import assertions (not strictly necessary to resolve #36 but falls in the category of ESM compatibility)

zetlen commented 1 year ago

Added a fix for an unexpected regression.

It looks like version 8.1.0 of docx has a regression where it'll return a Uint8Array instead of a Buffer if it can't tell it's running in Node. The intended behavior is documented here. I'll open the bug in docx when I can. I don't have the time to make a minimal repro for that, unfortunately.

zetlen commented 1 year ago

Whoops, forgot to actually update the snapshots! Stand by