search

inorbit-ai / ros_amr_interop

BSD 3-Clause "New" or "Revised" License
80 stars 27 forks source link

Upgrade from galactic to humble #31

Closed nv-yuzho closed 1 year ago

leandropineda commented 1 year ago

Hi @nv-yuzho !

Would you mind retargeting the PR against humble-devel? I just created it.

Why did you rename the package to vda5050_connector_py?

nv-yuzho commented 1 year ago

Hi @nv-yuzho !

Would you mind retargeting the PR against humble-devel? I just created it.

Why did you rename the package to vda5050_connector_py?

Hi @leandropineda! Yeah, I wanted to merge it to humble-devel but couldn't create one. Could you create one for the vda5050_adapter_examples repo as well? Regarding the rename, there is a known issue mentioned in the warning here and on another GitHub Issue. We wanted to mix action generator and python, but the ament_cmake_python commands couldn't handle this case very well. Thus I need to change the name of one python module to avoid conflict, otherwise, it would run into build errors. Not sure why it was ok for ROS galactic though.

leandropineda commented 1 year ago

I finally got the time to go through your PR @nv-yuzho and test everything. Thanks for your contribution! I'll continue with the PRs on https://github.com/inorbit-ai/vda5050_adapter_examples