search

inorbit-ai / ros_amr_interop

BSD 3-Clause "New" or "Revised" License
80 stars 27 forks source link

[VDA5050] Fix Stitch Orders and Schema Typos #42

Closed bobbleballs closed 1 year ago

bobbleballs commented 1 year ago

PR to fix the issue described in #40 Also added a test to verify the Stitch behaviour and enabled the test_vda5050_controller.py tests in the CMakeLists.txt file (Is there any reason why this wasn't enabled? The others aren't added but probably should be?)

This also fixes some typos that I've noticed in the schema whilst I was testing the controller with openTCS's implementation of VDA5050 found here

One thing I have noticed and will open a separate issue for is that some of the schemas are blending between VDA5050 V1.1 and VDA5050 V2.0. What is the version that this controller is targeting?

bobbleballs commented 1 year ago

@leandropineda thanks! Yeah, I've successfully been running this with actions on the stitch updates, however I have noticed the action duplication bug, it hasn't really been an issue for me. Re: the VDA5050 version I think the only blocker was with the "informations" field as mentioned in #43: I didn't fix this as I wasn't sure what you were targeting.