search

inorbit-ai / ros_amr_interop

BSD 3-Clause "New" or "Revised" License
75 stars 26 forks source link

Error Referance Keys Implementation camelCase or snakeCase #48

Open bekirbostanci opened 7 months ago

bekirbostanci commented 7 months ago

Actually when I looked vda5050 documentation it is really clear, All field names are in camelCase Old version of the repo it was camelCase but then with updates why it changed to snakeCase? image

Also at the error reference implementation at examples are camelCase image

https://github.com/inorbit-ai/ros_amr_interop/blob/bebd6d29952cc3f1121e715bb912db8474380d65/vda5050_connector/vda5050_connector_py/vda5050_controller.py#L1213

miguelgarcia commented 7 months ago

I +1 this one, references to VDA fields should be camelCased

bekirbostanci commented 7 months ago

should I create pullrequest for this one ?

miguelgarcia commented 7 months ago

Sure, go ahead :muscle: