search

inorganik / digest-auth-request

Make digest-auth requests with vanilla javascript
MIT License
70 stars 49 forks source link

improved success requests #24

Closed destebanm closed 8 years ago

destebanm commented 8 years ago

The problem was when a response returns HTTP status code 200 but responseText was empty (some services returns this kind of reponse). Now, with this code, this kind of response executes fires the success callback.

inorganik commented 8 years ago

Hmm - indentation is a bit borked. You have almost as many additions as deletions - in other words, you've replaced the whole file, which makes it very hard to read diffs. Can you please re-submit so that the only diffs are where your edits have been made?

inorganik commented 8 years ago

still the whole file is changed 😬

destebanm commented 8 years ago

So sorry,is the first time that i do a pull request :grimacing: Give me another try!

inorganik commented 8 years ago

that's ok. Just make a temp copy of your file, then do a git rebase master and make your edits again. then push and make a new PR.