search

inorton / EDMCJumpSpeed

A Jump Speed plugin for EDMC
19 stars 3 forks source link

Python 3.7 Support #4

Open Athanasius opened 4 years ago

Athanasius commented 4 years ago

Despite having a plugin_start3() which initially made me think this was updated for Python 3.7 it seems this plugin isn't fully ready after all.

https://github.com/inorton/EDMCJumpSpeed/blob/master/load.py#L203

is missing the 'is_beta' argument. There might be other such as well.

Confirm it's fixed up and tested as working and I'll move it back into the 'supported' section on https://github.com/EDCD/EDMarketConnector/wiki/Plugins

RapidfireCRH commented 4 years ago

Created a pr fixing the plugin. Working on 3.99.1.0 with added is_beta tag in journal_entry