search

inoryy / reaver

Reaver: Modular Deep Reinforcement Learning Framework. Focused on StarCraft II. Supports Gym, Atari, and MuJoCo.
MIT License
554 stars 89 forks source link

Fix default logger #18

Closed inoryy closed 5 years ago

inoryy commented 5 years ago

Current default is essentially /dev/null which is probably not the expected behavior for people trying to run reaver from inside their own codebase.

GabrielZH commented 5 years ago

So is this the cause of the AttributeError: 'AdvantageActorCriticAgent' object has no attribute 'logger' when trying to run a quickstart currently?

inoryy commented 5 years ago

Oh, seems I've broken it with some of the recent changes. As a temporary workaround you can manually initialize the /dev/null logger via agent.logger = rvr.utils.Logger(). Alternatively see how the full StreamLogger is initialized here.

GabrielZH commented 5 years ago

Thank you so much!

inoryy commented 5 years ago

Enabled StreamLogger by default with sensible configs in 2.1.5.