search

inossidabile / protector

Comfortable (seriously) white-list security restrictions for models on a field level
MIT License
270 stars 31 forks source link

Change :view to :read? #27

Closed johnrees closed 11 years ago

johnrees commented 11 years ago

I've always known the various user verbs be referred to as CRUD

Create Read Update Destroy

It seems like the standard option when looking through other gems e.g. cancan. Was there a reason behind using :view instead?

inossidabile commented 11 years ago

The reasons are mostly historical. I agree that :read might be a better name but I'm not really sure if we should change it now.

inossidabile commented 11 years ago

Okay, so here is the plan. We might want to deprecate :view with a notice and switch to :read as a main way to declare this. And later remove it on the way to 1.0.

johnrees commented 11 years ago

Sounds great! I only brought it up because it threw me a bit when I started to learn the internals. Great gem though :+1: