inotia00 / ReVanced_Extended

ReVanced Extended Issues/Request repo
697 stars 21 forks source link

bug: default video quality not working #1006

Closed Mohammedibrahim15 closed 1 year ago

Mohammedibrahim15 commented 1 year ago

Type

Other

Tools used

Revancify

Application

YouTube 18.16.39

Bug description

After the latest patches update, default video quality doesn’t Work as intended despite setting its value in settings. it is always AUTO in videos. I have uninstalled RVX and reinstalled it but that problem still exist photo_1_2023-05-11_14-54-43 photo_2_2023-05-11_14-54-43

Steps to reproduce

Step 1: Include default video quality patch Step 2: Run any youtube video

Relevant log output

INFO: Reading dex files 
INFO: Decoding AndroidManifest.xml only, because resources are not needed 
INFO: Skipping custom-branding-icon-afn-blue: Excluded by default 
INFO: Skipping custom-branding-icon-afn-red: Excluded by default 
INFO: Skipping custom-branding-icon-mmt: Excluded by default 
INFO: Skipping custom-branding-icon-revancify-blue: Excluded by default 
INFO: Skipping custom-branding-icon-revancify-red: Excluded by default 
INFO: Skipping custom-branding-name: Excluded by default 
INFO: Skipping force-hide-player-button-background: Excluded by default 
INFO: Skipping force-premium-heading: Excluded by default 
INFO: Skipping force-vp9-codec: Excluded by default 
INFO: Skipping materialyou: Excluded by default 
INFO: Merging inotia00-integrations-v0.107.6.apk 
INFO: Deleting existing resource cache directory 
INFO: Decoding resources 
INFO: bypass-ambient-mode-restrictions succeeded 
INFO: change-homepage succeeded 
INFO: custom-double-tap-length succeeded 
INFO: custom-package-name succeeded 
INFO: custom-seekbar-color succeeded 
INFO: custom-video-speed succeeded 
INFO: default-video-quality succeeded 
INFO: default-video-speed succeeded 
INFO: disable-haptic-feedback succeeded 
INFO: disable-hdr-video succeeded 
INFO: disable-landscape-mode succeeded 
INFO: disable-quic-protocol succeeded 
INFO: disable-startup-shorts-player succeeded 
INFO: enable-external-browser succeeded 
INFO: enable-minimized-playback succeeded 
INFO: enable-old-quality-layout succeeded 
INFO: enable-open-links-directly succeeded 
INFO: enable-seekbar-tapping succeeded 
INFO: enable-tablet-miniplayer succeeded 
INFO: enable-tablet-navigation-bar succeeded 
INFO: enable-timestamps-speed succeeded 
INFO: enable-wide-searchbar succeeded 
INFO: header-switch succeeded 
INFO: hide-account-menu succeeded 
INFO: hide-auto-captions succeeded 
INFO: hide-auto-player-popup-panels succeeded 
INFO: hide-autoplay-button succeeded 
INFO: hide-autoplay-preview succeeded 
INFO: hide-breaking-news-shelf succeeded 
INFO: hide-button-container succeeded 
INFO: hide-captions-button succeeded 
INFO: hide-cast-button succeeded 
INFO: hide-category-bar succeeded 
INFO: hide-channel-avatar-section succeeded 
INFO: hide-channel-watermark succeeded 
INFO: hide-collapse-button succeeded 
INFO: hide-comment-component succeeded 
INFO: hide-crowdfunding-box succeeded 
INFO: hide-double-tap-overlay-filter succeeded 
INFO: hide-email-address succeeded 
INFO: hide-endscreen-cards succeeded 
INFO: hide-endscreen-overlay succeeded 
INFO: hide-filmstrip-overlay succeeded 
INFO: hide-floating-microphone succeeded 
INFO: hide-flyout-panel succeeded 
INFO: hide-fullscreen-panels succeeded 
INFO: hide-general-ads succeeded 
INFO: hide-info-cards succeeded 
INFO: hide-live-chat-button succeeded 
INFO: hide-load-more-button succeeded 
INFO: hide-mix-playlists succeeded 
INFO: hide-music-button succeeded 
INFO: hide-navigation-buttons succeeded 
INFO: hide-navigation-label succeeded 
INFO: hide-pip-notification succeeded 
INFO: hide-player-button-background succeeded 
INFO: hide-player-overlay-filter succeeded 
INFO: hide-previous-next-button succeeded 
INFO: hide-quick-actions succeeded 
INFO: hide-search-terms succeeded 
INFO: hide-seek-message succeeded 
INFO: hide-seekbar succeeded 
INFO: hide-shorts-component succeeded 
INFO: hide-shorts-navbar succeeded 
INFO: hide-snack-bar succeeded 
INFO: hide-stories succeeded 
INFO: hide-suggested-actions succeeded 
INFO: hide-time-stamp succeeded 
INFO: hide-tooltip-content succeeded 
INFO: hide-video-ads succeeded 
INFO: layout-switch succeeded 
INFO: microg-support succeeded 
INFO: optimize-resource succeeded 
INFO: overlay-buttons succeeded 
INFO: protobuf-spoof succeeded 
INFO: return-youtube-dislike succeeded 
INFO: settings succeeded 
INFO: sponsorblock succeeded 
INFO: spoof-app-version succeeded 
INFO: swipe-controls succeeded 
INFO: theme succeeded 
INFO: translations succeeded 
INFO: Compiling resources 
INFO: Writing modified dex files 
INFO: Aligning YouTube-18-16-39.apk to YouTube-Revanced-Extended-18-16-39_aligned.apk 
INFO: Signing YouTube-Revanced-Extended-18-16-39_aligned.apk to YouTube-Revanced-Extended-18-16-39_signed.apk 
INFO: Found existing keystore: revanced.keystore 
INFO: Copying YouTube-Revanced-Extended-18-16-39_signed.apk to YouTube-Revanced-Extended-18-16-39.apk 
INFO: Cleaned up cache directory 
INFO: Finished 

Variant: nonRoot
Arch: arm64-v8a
App: YouTube-18-16-39.apk
CLI: inotia00-cli-v2.21.2.jar
Patches: inotia00-patches-v2.173.6.jar
Integrations: inotia00-integrations-v0.107.6.apk
Patches argument: -i bypass-ambient-mode-restrictions
-i change-homepage
-i custom-double-tap-length
-i custom-package-name
-i custom-seekbar-color
-i custom-video-speed
-i default-video-quality
-i default-video-speed
-i disable-haptic-feedback
-i disable-hdr-video
-i disable-landscape-mode
-i disable-quic-protocol
-i disable-startup-shorts-player
-i enable-external-browser
-i enable-minimized-playback
-i enable-old-quality-layout
-i enable-open-links-directly
-i enable-seekbar-tapping
-i enable-tablet-miniplayer
-i enable-tablet-navigation-bar
-i enable-timestamps-speed
-i enable-wide-searchbar
-i header-switch
-i hide-account-menu
-i hide-auto-captions
-i hide-auto-player-popup-panels
-i hide-autoplay-button
-i hide-autoplay-preview
-i hide-breaking-news-shelf
-i hide-button-container
-i hide-captions-button
-i hide-cast-button
-i hide-category-bar
-i hide-channel-avatar-section
-i hide-channel-watermark
-i hide-collapse-button
-i hide-comment-component
-i hide-crowdfunding-box
-i hide-double-tap-overlay-filter
-i hide-email-address
-i hide-endscreen-cards
-i hide-endscreen-overlay
-i hide-filmstrip-overlay
-i hide-floating-microphone
-i hide-flyout-panel
-i hide-fullscreen-panels
-i hide-general-ads
-i hide-info-cards
-i hide-live-chat-button
-i hide-load-more-button
-i hide-mix-playlists
-i hide-music-button
-i hide-navigation-buttons
-i hide-navigation-label
-i hide-pip-notification
-i hide-player-button-background
-i hide-player-overlay-filter
-i hide-previous-next-button
-i hide-quick-actions
-i hide-search-terms
-i hide-seek-message
-i hide-seekbar
-i hide-shorts-component
-i hide-shorts-navbar
-i hide-snack-bar
-i hide-stories
-i hide-suggested-actions
-i hide-time-stamp
-i hide-tooltip-content
-i hide-video-ads
-i layout-switch
-i microg-support
-i optimize-resource
-i overlay-buttons
-i protobuf-spoof
-i return-youtube-dislike
-i settings
-i sponsorblock
-i spoof-app-version
-i swipe-controls
-i theme
-i translations

Screenshots or videos

added before

Solution

.

Additional context

.

Device Environment

Android 12

Acknowledgements

inotia00 commented 1 year ago

If anyone reproduces the issue please leave a comment

It doesn't reproduce on my side

Mohammed1520 commented 1 year ago

I have the same issue .. to solve it you should change default quality (as example you should change it from 360 to 480) then restart app and change it again from 480 to 360 .. it will work . I don't know what is the cause if the problem but i hope this solution will work

Edit This method fail to work .. if you close app and open it again after some minutes you will see AUTO option appear again in video quality

Hennadz commented 1 year ago

In fact, the quality of the video does not change. The mark of current quality is missing.

Screenshot_20230511-164254_EnTube

Screenshot_20230511-164321_EnTube

Screenshot_20230511-165809_EnTube

Screenshot_20230511-163627_EnTube

Sometimes this works correctly:

Screenshot_20230511-163239_EnTube

Mohammed1520 commented 1 year ago

Regarding this issue. Everything was working fine until the latest update today . I try to log out my account as a try but the same problem still exists

Mohammedibrahim15 commented 1 year ago

Everything was fine until this commit fix(youtube/default-video-quality): fix default video quality/speed being applied when resuming app And this issue also happen even if i turned default video quality setting to AUTO and depend on save video quality settings . I have to use YouTube with Revanced patches v2.173.4 until there is a fix for that problem

HundedFifteeTree commented 1 year ago

The video is 720p:

237713195-130e1f61-d983-4372-bf08-cf29d468e9cd

The picker doesn't show 720p as selected, because the quality was already 720p when the video was opened.
Since you changed the built in YouTube video quality to "higher quality", then videos are usually already pre-set to 720p.

Not a bug.

Mohammedibrahim15 commented 1 year ago

quality1 In my country the internet is limited so I extremely need default quality in all videos . Look at this image from Youtube built with Revanced patches v2.173.4 the quality is set to be 360 and no AUTO option detected. But in recent version of revanced patches there is AUTO(360) option and the video quality is higher than 360 in this case. in all videos with that patches version every time I play any video I have to set the quality manually

inotia00 commented 1 year ago

In revanced-patches-v2.173.10, I rolled back commits related to default video quality

Try the patch again with revanced-patches-v2.173.10 and check if the issue is reproduced

Mohammedibrahim15 commented 1 year ago

Now everything works fine and the issue disappear 👍