inotia00 / ReVanced_Extended

ReVanced Extended Issues/Request repo
733 stars 29 forks source link

bug: custom package name not applied #1130

Closed aurarora closed 1 year ago

aurarora commented 1 year ago

Type

Error while patching

Tools used

Revancify

Application

Patches Version 2.184.3

Bug description

While patching in Revancify the custom package name doesn't get applied, even though the log says it succeeded.

Steps to reproduce

  1. Include custom-package-name
  2. Set custom package name
  3. Patch Youtube
  4. Log says custom package name succeeded
  5. Notice the patched apk has default package name

Relevant log output

INFO: Reading dex files 
INFO: Decoding AndroidManifest.xml only, because resources are not needed 
INFO: Skipping add-splash-animation: Excluded by default 
INFO: Skipping custom-branding-icon-revancify-blue: Excluded by default 
INFO: Skipping custom-branding-icon-revancify-red: Excluded by default 
INFO: Skipping enable-debug-logging: Excluded by default 
INFO: Skipping force-hide-player-button-background: Excluded by default 
INFO: Skipping force-premium-heading: Excluded by default 
INFO: Skipping theme: Excluded by default 
INFO: Merging inotia00-integrations-v0.112.3.apk 
INFO: Deleting existing resource cache directory 
INFO: Decoding resources 
INFO: Executing patches 
INFO: Bypass ambient mode restrictions succeeded 
INFO: Change homepage succeeded 
INFO: Custom branding YouTube name succeeded 
INFO: Custom branding icon MMT succeeded 
INFO: Custom double tap length succeeded 
INFO: Custom package name succeeded 
INFO: Custom seekbar color succeeded 
INFO: Custom video speed succeeded 
INFO: Default video quality succeeded 
INFO: Default video speed succeeded 
INFO: Disable QUIC protocol succeeded 
INFO: Disable Shorts on startup succeeded 
INFO: Disable auto captions succeeded 
INFO: Disable haptic feedback succeeded 
INFO: Disable hdr video succeeded 
INFO: Disable landscape mode succeeded 
INFO: Disable pip notification succeeded 
INFO: Enable compact controls overlay succeeded 
INFO: Enable external browser succeeded 
INFO: Enable minimized playback succeeded 
INFO: Enable new comment popup panels succeeded 
INFO: Enable new splash animation succeeded 
INFO: Enable new thumbnail preview succeeded 
INFO: Enable old quality layout succeeded 
INFO: Enable open links directly succeeded 
INFO: Enable seekbar tapping succeeded 
INFO: Enable tablet mini player succeeded 
INFO: Enable tablet navigation bar succeeded 
INFO: Enable time stamps speed succeeded 
INFO: Enable wide search bar succeeded 
INFO: Force OPUS codec succeeded 
INFO: Force VP9 codec succeeded 
INFO: Header switch succeeded 
INFO: Hide Shorts components succeeded 
INFO: Hide account menu succeeded 
INFO: Hide auto player popup panels succeeded 
INFO: Hide autoplay button succeeded 
INFO: Hide autoplay preview succeeded 
INFO: Hide button container succeeded 
INFO: Hide captions button succeeded 
INFO: Hide cast button succeeded 
INFO: Hide category bar succeeded 
INFO: Hide channel avatar section succeeded 
INFO: Hide channel watermark succeeded 
INFO: Hide collapse button succeeded 
INFO: Hide comment component succeeded 
INFO: Hide crowdfunding box succeeded 
INFO: Hide description components succeeded 
INFO: Hide double tap overlay filter succeeded 
INFO: Hide end screen cards succeeded 
INFO: Hide end screen overlay succeeded 
INFO: Hide feed flyout panel succeeded 
INFO: Hide filmstrip overlay succeeded 
INFO: Hide floating microphone succeeded 
INFO: Hide fullscreen panels succeeded 
INFO: Hide general ads succeeded 
INFO: Hide handle succeeded 
INFO: Hide info cards succeeded 
INFO: Hide layout components succeeded 
INFO: Hide load more button succeeded 
INFO: Hide mix playlists succeeded 
INFO: Hide music button succeeded 
INFO: Hide navigation buttons succeeded 
INFO: Hide navigation label succeeded 
INFO: Hide player button background succeeded 
INFO: Hide player flyout panel succeeded 
INFO: Hide player overlay filter succeeded 
INFO: Hide previous next button succeeded 
INFO: Hide quick actions succeeded 
INFO: Hide seek message succeeded 
INFO: Hide seekbar succeeded 
INFO: Hide snack bar succeeded 
INFO: Hide speed overlay succeeded 
INFO: Hide suggested actions succeeded 
INFO: Hide suggestions shelf succeeded 
INFO: Hide time stamp succeeded 
INFO: Hide tooltip content succeeded 
INFO: Hide trending searches succeeded 
INFO: Hide video ads succeeded 
INFO: Language switch succeeded 
INFO: Layout switch succeeded 
INFO: MaterialYou succeeded 
INFO: MicroG support succeeded 
INFO: Optimize resource succeeded 
INFO: Overlay buttons succeeded 
INFO: Return YouTube Dislike succeeded 
INFO: Settings succeeded 
INFO: Sponsorblock succeeded 
INFO: Spoof app version succeeded 
INFO: Spoof player parameters succeeded 
INFO: Swipe controls succeeded 
INFO: Translations succeeded 
INFO: Compiling resources 
INFO: Writing modified dex files 
INFO: Aligning base.apk to base-Revanced-Extended_aligned.apk 
INFO: Signing base-Revanced-Extended_aligned.apk to base-Revanced-Extended_signed.apk 
INFO: Found existing keystore: revancify.keystore 
INFO: Copying base-Revanced-Extended_signed.apk to base-Revanced-Extended.apk 
INFO: Cleaned up cache directory 
INFO: Finished 

Variant: nonRoot
Arch: arm64-v8a
App: YouTube v18.25.40
CLI: inotia00-cli-v2.22.1.jar
Patches: inotia00-patches-v2.184.3.jar
Integrations: inotia00-integrations-v0.112.3.apk
Patches argument: -i bypass-ambient-mode-restrictions
-i change-homepage
-i custom-branding-youtube-name
-i custom-branding-icon-mmt
-i custom-double-tap-length
-i custom-package-name
-i custom-seekbar-color
-i custom-video-speed
-i default-video-quality
-i default-video-speed
-i disable-quic-protocol
-i disable-shorts-on-startup
-i disable-auto-captions
-i disable-haptic-feedback
-i disable-hdr-video
-i disable-landscape-mode
-i disable-pip-notification
-i enable-compact-controls-overlay
-i enable-external-browser
-i enable-minimized-playback
-i enable-new-comment-popup-panels
-i enable-new-splash-animation
-i enable-new-thumbnail-preview
-i enable-old-quality-layout
-i enable-open-links-directly
-i enable-seekbar-tapping
-i enable-tablet-mini-player
-i enable-tablet-navigation-bar
-i enable-time-stamps-speed
-i enable-wide-search-bar
-i force-opus-codec
-i force-vp9-codec
-i header-switch
-i hide-shorts-components
-i hide-account-menu
-i hide-auto-player-popup-panels
-i hide-autoplay-button
-i hide-autoplay-preview
-i hide-button-container
-i hide-captions-button
-i hide-cast-button
-i hide-category-bar
-i hide-channel-avatar-section
-i hide-channel-watermark
-i hide-collapse-button
-i hide-comment-component
-i hide-crowdfunding-box
-i hide-description-components
-i hide-double-tap-overlay-filter
-i hide-end-screen-cards
-i hide-end-screen-overlay
-i hide-feed-flyout-panel
-i hide-filmstrip-overlay
-i hide-floating-microphone
-i hide-fullscreen-panels
-i hide-general-ads
-i hide-handle
-i hide-info-cards
-i hide-layout-components
-i hide-load-more-button
-i hide-mix-playlists
-i hide-music-button
-i hide-navigation-buttons
-i hide-navigation-label
-i hide-player-button-background
-i hide-player-flyout-panel
-i hide-player-overlay-filter
-i hide-previous-next-button
-i hide-quick-actions
-i hide-seek-message
-i hide-seekbar
-i hide-snack-bar
-i hide-speed-overlay
-i hide-suggested-actions
-i hide-suggestions-shelf
-i hide-time-stamp
-i hide-tooltip-content
-i hide-trending-searches
-i hide-video-ads
-i language-switch
-i layout-switch
-i materialyou
-i microg-support
-i optimize-resource
-i overlay-buttons
-i return-youtube-dislike
-i settings
-i sponsorblock
-i spoof-app-version
-i spoof-player-parameters
-i swipe-controls
-i translations

Screenshots or videos

No response

Solution

No response

Additional context

No response

Device Environment

No response

Acknowledgements

inotia00 commented 1 year ago

I tested it a while ago and it works fine

revanced-patches-v2.184.3 has some pretty big changes, so you need to rewrite options.json

Remove options.json from Revancify, then edit options.json again

aurarora commented 1 year ago

Deleting Patch options in Revancify worked. Thanks for responding so quickly!