bug: weird behaviour in `new thumbnail preview`

sleepingiv commented 1 year ago

Type

Error at runtime

Tools used

Revancify

Application

YouTube 18.25.40

Bug description

Thumbnail preview of previously played video appears after first seeking of currently playing video , it fixes after scrubbing a bit more.

Steps to reproduce

Do the same as shown in the video.

Relevant log output

INFO: Reading dex files 
INFO: Decoding AndroidManifest.xml only, because resources are not needed 
INFO: Skipping bypass-ambient-mode-restrictions: Excluded by default 
INFO: Skipping change-homepage: Excluded by default 
INFO: Skipping custom-branding-youtube-name: Excluded by default 
INFO: Skipping custom-branding-icon-mmt: Excluded by default 
INFO: Skipping custom-branding-icon-revancify-blue: Excluded by default 
INFO: Skipping custom-branding-icon-revancify-red: Excluded by default 
INFO: Skipping custom-double-tap-length: Excluded by default 
INFO: Skipping custom-package-name: Excluded by default 
INFO: Skipping disable-quic-protocol: Excluded by default 
INFO: Skipping disable-haptic-feedback: Excluded by default 
INFO: Skipping disable-hdr-video: Excluded by default 
INFO: Skipping disable-landscape-mode: Excluded by default 
INFO: Skipping enable-compact-controls-overlay: Excluded by default 
INFO: Skipping enable-debug-logging: Excluded by default 
INFO: Skipping enable-external-browser: Excluded by default 
INFO: Skipping enable-tablet-mini-player: Excluded by default 
INFO: Skipping enable-tablet-navigation-bar: Excluded by default 
INFO: Skipping enable-wide-search-bar: Excluded by default 
INFO: Skipping force-opus-codec: Excluded by default 
INFO: Skipping force-vp9-codec: Excluded by default 
INFO: Skipping force-hide-player-button-background: Excluded by default 
INFO: Skipping force-premium-heading: Excluded by default 
INFO: Skipping header-switch: Excluded by default 
INFO: Skipping hide-category-bar: Excluded by default 
INFO: Skipping hide-collapse-button: Excluded by default 
INFO: Skipping hide-double-tap-overlay-filter: Excluded by default 
INFO: Skipping hide-end-screen-overlay: Excluded by default 
INFO: Skipping hide-filmstrip-overlay: Excluded by default 
INFO: Skipping hide-fullscreen-panels: Excluded by default 
INFO: Skipping hide-handle: Excluded by default 
INFO: Skipping hide-load-more-button: Excluded by default 
INFO: Skipping hide-music-button: Excluded by default 
INFO: Skipping hide-player-button-background: Excluded by default 
INFO: Skipping hide-player-overlay-filter: Excluded by default 
INFO: Skipping hide-previous-next-button: Excluded by default 
INFO: Skipping hide-quick-actions: Excluded by default 
INFO: Skipping hide-seekbar: Excluded by default 
INFO: Skipping hide-suggested-actions: Excluded by default 
INFO: Skipping hide-suggestions-shelf: Excluded by default 
INFO: Skipping hide-time-stamp: Excluded by default 
INFO: Skipping language-switch: Excluded by default 
INFO: Skipping layout-switch: Excluded by default 
INFO: Skipping spoof-app-version: Excluded by default 
INFO: Skipping translations: Excluded by default 
INFO: Merging inotia00-integrations-v0.112.3.apk 
INFO: Deleting existing resource cache directory 
INFO: Decoding resources 
INFO: Executing patches 
INFO: Add splash animation succeeded 
INFO: Custom seekbar color succeeded 
INFO: Custom video speed succeeded 
INFO: Default video quality succeeded 
INFO: Default video speed succeeded 
INFO: Disable Shorts on startup succeeded 
INFO: Disable auto captions succeeded 
INFO: Disable pip notification succeeded 
INFO: Enable minimized playback succeeded 
INFO: Enable new comment popup panels succeeded 
INFO: Enable new splash animation succeeded 
INFO: Enable new thumbnail preview succeeded 
INFO: Enable old quality layout succeeded 
INFO: Enable open links directly succeeded 
INFO: Enable seekbar tapping succeeded 
INFO: Enable time stamps speed succeeded 
INFO: Hide Shorts components succeeded 
INFO: Hide account menu succeeded 
INFO: Hide auto player popup panels succeeded 
INFO: Hide autoplay button succeeded 
INFO: Hide autoplay preview succeeded 
INFO: Hide button container succeeded 
INFO: Hide captions button succeeded 
INFO: Hide cast button succeeded 
INFO: Hide channel avatar section succeeded 
INFO: Hide channel watermark succeeded 
INFO: Hide comment component succeeded 
INFO: Hide crowdfunding box succeeded 
INFO: Hide description components succeeded 
INFO: Hide end screen cards succeeded 
INFO: Hide feed flyout panel succeeded 
INFO: Hide floating microphone succeeded 
INFO: Hide general ads succeeded 
INFO: Hide info cards succeeded 
INFO: Hide layout components succeeded 
INFO: Hide mix playlists succeeded 
INFO: Hide navigation buttons succeeded 
INFO: Hide navigation label succeeded 
INFO: Hide player flyout panel succeeded 
INFO: Hide seek message succeeded 
INFO: Hide snack bar succeeded 
INFO: Hide speed overlay succeeded 
INFO: Hide tooltip content succeeded 
INFO: Hide trending searches succeeded 
INFO: Hide video ads succeeded 
INFO: MaterialYou succeeded 
INFO: MicroG support succeeded 
INFO: Optimize resource succeeded 
INFO: Overlay buttons succeeded 
INFO: Return YouTube Dislike succeeded 
INFO: Settings succeeded 
INFO: Sponsorblock succeeded 
INFO: Spoof player parameters succeeded 
INFO: Swipe controls succeeded 
INFO: Theme succeeded 
INFO: Compiling resources 
INFO: Writing modified dex files 
INFO: Aligning base.apk to base-Revanced-Extended_aligned.apk 
INFO: Signing base-Revanced-Extended_aligned.apk to base-Revanced-Extended_signed.apk 
INFO: Found existing keystore: revancify.keystore 
INFO: Copying base-Revanced-Extended_signed.apk to base-Revanced-Extended.apk 
INFO: Cleaned up cache directory 
INFO: Finished 

Variant: nonRoot
Arch: arm64-v8a
App: YouTube v18.25.40
CLI: inotia00-cli-v2.22.1.jar
Patches: inotia00-patches-v2.184.3.jar
Integrations: inotia00-integrations-v0.112.3.apk
Patches argument: -i add-splash-animation
-i custom-seekbar-color
-i custom-video-speed
-i default-video-quality
-i default-video-speed
-i disable-shorts-on-startup
-i disable-auto-captions
-i disable-pip-notification
-i enable-minimized-playback
-i enable-new-comment-popup-panels
-i enable-new-splash-animation
-i enable-new-thumbnail-preview
-i enable-old-quality-layout
-i enable-open-links-directly
-i enable-seekbar-tapping
-i enable-time-stamps-speed
-i hide-shorts-components
-i hide-account-menu
-i hide-auto-player-popup-panels
-i hide-autoplay-button
-i hide-autoplay-preview
-i hide-button-container
-i hide-captions-button
-i hide-cast-button
-i hide-channel-avatar-section
-i hide-channel-watermark
-i hide-comment-component
-i hide-crowdfunding-box
-i hide-description-components
-i hide-end-screen-cards
-i hide-feed-flyout-panel
-i hide-floating-microphone
-i hide-general-ads
-i hide-info-cards
-i hide-layout-components
-i hide-mix-playlists
-i hide-navigation-buttons
-i hide-navigation-label
-i hide-player-flyout-panel
-i hide-seek-message
-i hide-snack-bar
-i hide-speed-overlay
-i hide-tooltip-content
-i hide-trending-searches
-i hide-video-ads
-i materialyou
-i microg-support
-i optimize-resource
-i overlay-buttons
-i return-youtube-dislike
-i settings
-i sponsorblock
-i spoof-player-parameters
-i swipe-controls
-i theme

Screenshots or videos

https://github.com/inotia00/ReVanced_Extended/assets/64865031/310876ee-80ce-4517-ae3a-0cde95eb30c4

Solution

No response

Additional context

No response

Device Environment

Android 13, MIUI 14

Acknowledgements

[X] I have searched the existing issues and this is a new and no duplicate or related to another open issue.
[X] I have written a short but informative title.
[X] I filled out all of the requested information in this issue properly.
[x] I have written the title and contents in English.
[x] This issue does not reproduce on unpatched YouTube or YT Music.

inotia00 commented 1 year ago

It is a New Thumbnail Preview

This feature is being tested by Google for specific users (A/B tests)

(This is not a bug..)

Even if you haven't been targeted for A/B testing, including the enable-new-thumbnail-preview patch will force enable it.

sleepingiv commented 1 year ago

I am aware that I am using the new thumbnail preview , and I mentioned the behaviour that's happening in it.

You can clearly see that the thumbnail preview of mkbhd's video is shown in ltt's video on the first scrub.

See if you can reproduce it.

inotia00 commented 1 year ago

yep i checked the video

The video you attached is what it looks like when Enable new thumbnail preview works.

If what you're talking about is that thumbnail previews aren't reflected in real time, that's a side effect of the spoof-player-parameter patch.

sleepingiv commented 1 year ago

Can it be fixed ?

inotia00 commented 1 year ago

I have been trying to fix this issue since January of this year, but without success

I have a vague expectation that it will be fixed by someone someday ¯_(ツ)_/¯

sleepingiv commented 1 year ago

No worries.

inotia00 / ReVanced_Extended