bug: correct/modify spaces in overlay buttons patch

MondayNitro commented 11 months ago

Type

Cosmetic

Tools used

ReVanced Manager

Application

youtube 18.25.40

Bug description

i began using overlay buttons patch for ytdlnis yesterday and i saw that the contents above the seekbar shift towards the seekbar if you patch using overlay buttons patch, due to which the vertical space between seekbar and overlay buttons, fullscreen buttons. timestamps etc. gets reduced. to top it off, my device screen is small (5 in) which leads to accidentally tapping seekbar instead of overlay buttons. i request you to keep the vertical space like it is when you dont include overlay buttons patch, so users with devices having low screen size dont tap the seekbar accidentally

Steps to reproduce

compare rvx apks patched with and without overlay buttons patch to see the difference.

Relevant log output

none

Screenshots or videos

photo_6142941357120010975_w photo_6142941357120010974_w

Solution

No response

Additional context

No response

Device Environment

LOS20

Acknowledgements

[X] I have searched the existing issues and this is a new and no duplicate or related to another open issue.
[X] I have written a short but informative title.
[X] I filled out all of the requested information in this issue properly.
[X] I have written the title and contents in English.
[X] This issue does not reproduce on unpatched YouTube or YT Music.

MondayNitro commented 11 months ago

also, would you consider thinning the overlay buttons a bit, because they look thicker than the fullscreen button

inotia00 commented 11 months ago

First of all this is not a bug

Someone pointed out that the height of the overlay button and the timestamp are different, so I just unified them.

If this patch is introduced as a PR and merged, I think it will solve what you want.

MondayNitro commented 11 months ago

First of all this is not a bug

Someone pointed out that the height of the overlay button and the timestamp are different, so I just unified them.

If this patch is introduced as a PR and merged, I think it will solve what you want.

no, it doesnt. i checked in rex too. that patch lifts the seekbar only. it doesnt increase the vertical space bw seekbar and overlay buttons.

inotia00 / ReVanced_Extended