inotia00 / ReVanced_Extended

ReVanced Extended Issues/Request repo
706 stars 21 forks source link

bug: <themes> light theme not working #1631

Closed Rairof closed 11 months ago

Rairof commented 11 months ago

Type

Cosmetic

Tools used

ReVanced Manager

Application

YouTube v18.40.34

Bug description

Light theme not working but dark theme patch works as intended. Light theme just stays on defaut white theme and doesn't change to selected theme within light theme colours within the theme patch option.

Steps to reproduce

  1. Patch youtube with latest patches
  2. Including themes option and both dark, light themes selected and saved within patch options
  3. Install patched YouTube and open using dark and light mode to see if it works or not.

Relevant log output

N/A

Screenshots or videos

Screenshot_2023-10-31-18-24-48-579_app rvx android youtube-edit Screenshot_2023-10-31-18-25-02-649_app rvx android youtube-edit Screenshot_2023-10-31-18-25-25-772_app rvx manager flutter-edit

Solution

Fix light theme patch option.

Additional context

Using Xiaomi 11t pro phone

Device Environment

Android 13 MIUI14.0.4

Acknowledgements

inotia00 commented 11 months ago

Please upload the following screenshot

Settings > ReVanced Extended > Miscellaneous > Patch Information > (scroll down) > Theme

Theme

Rairof commented 11 months ago

https://github.com/inotia00/ReVanced_Extended/issues/1631#issuecomment-1787195147 Here ya go. Screenshot_2023-10-31-19-03-29-618_app rvx android youtube-edit

inotia00 commented 11 months ago

The priority of themes is as follows:

MaterialYou Light > Light Theme

Dark Theme > MaterialYou Dark

You included MaterialYou

Therefore, MaterialYou Light's theme was applied

If you want to use the Light Theme, you should exclude the MaterialYou patch

Rairof commented 11 months ago

https://github.com/inotia00/ReVanced_Extended/issues/1631#issuecomment-1787383565 I figured, but I don't like those default Red notifs over custom themes so I use material you patch with it which used to work... Can light theme be prioritised over material you theme like in dark theme?