search

inotia00 / ReVanced_Extended

ReVanced Extended Issues/Request repo
734 stars 29 forks source link

bug: RVX Manager doesn't display apps that aren't installed #2038

Closed KobeW50 closed 6 months ago

KobeW50 commented 6 months ago

Type

Other

Application

RVX Manager v1.20.2

Bug description

When a patchable app (ie: YouTube, YT Music, or Reddit) is not installed it does not appear in the app list in the RVX Manager. This makes it difficult for users to determine what the suggested version is for that app.

Example

Here is a screenshot from the ReVanced Manager, which correctly shows the app list when only YouTube is installed:

Screenshot_20240516_121051_ReVanced Manager

Here is a screenshot from RVX Manager:

Screenshot_20240516_121102_RVX Manager

Error logs

No response

Solution

No response

Additional context

No response

Device Environment

Android 14 S22+ OneUI 6

Acknowledgements

inotia00 commented 6 months ago

This feature has not been provided since RVX Manager was first forked. Here's why:

  1. For some reason, RVX Manager uses the app list provided by the official ReVanced. : Therefore, there was a bug where a list of apps not provided by RVX Patches was displayed. e.g. RVX patch does not provide a patch for Spotify, but it recognizes that it supports Spotify, so Spotify is displayed in the not installed app list.

  2. RVX patch supports only three apps: YouTube, YT Music, and Reddit. : Therefore, there is no major inconvenience without displaying the list of apps that are not installed.

For this reason, the list of not installed apps is hidden by default by commit https://github.com/inotia00/revanced-manager/commit/a00750bc69c197905b694508e4804145ae2fc1c5.

This has been maintained since the RVX Manager was first forked, and if this 'bug' is not reproduced in the latest ReVanced Manager, it would be okay to roll back the commit.

inotia00 commented 6 months ago
  1. For some reason, RVX Manager uses the app list provided by the official ReVanced. : Therefore, there was a bug where a list of apps not provided by RVX Patches was displayed. e.g. RVX patch does not provide a patch for Spotify, but it recognizes that it supports Spotify, so Spotify is displayed in the not installed app list.

I checked and found that this bug was a valid bug in rvx manager v1.3.8, when rvx manager was first forked, but it is no longer reproduced now.

About a year has passed since rvx manager was first forked, and it seems that this bug was fixed at some point.

I think it would be okay to roll back the commit https://github.com/inotia00/revanced-manager/commit/a00750bc69c197905b694508e4804145ae2fc1c5

inotia00 commented 6 months ago

reflected in rvx manager 1.20.3

Francesco146 commented 6 months ago

I'm still facing this in the latest release. does this apply only for the default source? (not the alternative one's)

Screenshot_20240519_084959_RVX Manager

inotia00 commented 6 months ago

I'm not sure. I haven't tested it on anything other than the default source and the RVX fork.

jsjajajjajaashhbsbabhsshhshs commented 5 months ago

I can't update the app it's always stuck at " Downloading update . . . "

KobeW50 commented 5 months ago

I can't update the app it's always stuck at " Downloading update . . . "

You can download the newest apk from inotia00's ReVanced Manager repository