inotia00 / ReVanced_Extended

ReVanced Extended Issues/Request repo
655 stars 20 forks source link

bug (YouTube): `Navigation bar` elements is not hiding, when they have new icons #2169

Open GucekPL opened 1 week ago

GucekPL commented 1 week ago

Type

Error at runtime

Tools used

RVX Manager

Application

YT app version: 19.21.40 Patches version: 4.9.1

Bug description

Today, YouTube decided to endow my Google account with new navigation bar icons. Along with this, hiding the notification button no longer works.

Steps to reproduce:

  1. Make sure you have the icons as in the screenshot below image
  2. Enable Swap Create and Notifications buttons and Hide notifications button in the Navigation buttons options image
  3. As shown, notifications button is still showing image

Error logs

No response

Solution

No response

Additional context

No response

Device Environment

No response

Acknowledgements

GucekPL commented 1 week ago

I would also add that I checked the option to hide the notification button in the toolbar, and it doesn't work too

inotia00 commented 1 week ago

It looks like A/B tests Not only the Notification button, but also other buttons are not hidden? (Home, Shorts, Scubscriptions, etc..)

GucekPL commented 1 week ago

Navigation bar:

Toolbar:

inotia00 commented 1 week ago

These are clearly A/B tests

If this issue still occurs on your account, could you please provide the debug log?

GucekPL commented 1 week ago

How to do that? I have never done this

inotia00 commented 1 week ago

1. Turn on the following settings:

Settings - ReVanced Extended - Miscellaneous - Enable debug logging

2. Launch termux

3. In termux, enter the following command:

logcat | grep Extended > /storage/emulated/0/logcat.txt

(You can copy and paste by press and hold)

4. Force close and launch the RVX again

5. After about 10 seconds, return to termux and click the CTRL button, and then click the C on the keyboard

6. The logcat.txt file generated in the internal storage (/sdcard/logcat.txt)

7. Upload logcat.txt

EDITED: The debug log does not appear to be displayed correctly on Termux..

inotia00 commented 1 week ago
  1. Download and install the Locat Reader app:

F-Droid (summary) F-Droid (direct download)

  1. Enable USB debugging and grant permission by entering the following command from the CMD on your PC:
adb shell "pm grant com.dp.logcatapp android.permission.READ_LOGS && am force-stop com.dp.logcatapp"
  1. Launch the Locat Reader app

  2. Move to 3dot menu - Filters

  3. Click the + button and type it like a screenshot:

LogCatReader

and then, click OK

  1. In RVX, turn on the following settings:

    Settings - ReVanced Extended - Miscellaneous - Enable debug logging
  2. Force close and launch the RVX again

  3. After about 10 seconds, back to the Locat Reader app and screen capture

Capture

GucekPL commented 1 week ago

Okay, tysm, I will do this later

GucekPL commented 1 week ago

@inotia00 image I have only 2 logs after opening RVX

inotia00 commented 1 week ago

Thanks.. I think the Cairo icon cannot be identified by the Enum value (requires deeper debugging)

It seems that a fix is ​​only possible when this A/B test is applied to my account

btw Cairo icon for navigation bar was added in YouTube 19.20.35, so using YouTube 19.16.39 may solve the issue

inotia00 commented 1 week ago

One last thing, please test that the Hide navigation labels setting works

GucekPL commented 1 week ago

Works

GucekPL commented 1 day ago

@inotia00 1 hour ago, Google reverted for my account new Cairo-icons, so all works perfectly again. LMAO 😅