inotia00 / ReVanced_Extended

ReVanced Extended Issues/Request repo
655 stars 20 forks source link

bug(Reddit) : Some patches are not working on Reddit `2024.26.1`+ #2200

Open Aryan-Chauhan opened 3 days ago

Aryan-Chauhan commented 3 days ago

Type

Error at runtime

Tools used

Revancify

Application

Reddit v2024.26.1, but wasn't working in v2024.25.3 either.

Patches: https://github.com/inotia00/revanced-patches-arsclib/releases/tag/v2.177.1

Integrations: https://github.com/inotia00/revanced-integrations/releases/tag/v1.11.1-dev.1

Bug description

Remove Notification Suggestion Dialog is enabled in the settings, but it is not working. To reproduce it:

  1. Go to any subscribed subreddit that you've never visited before.
  2. Open any post & scroll a bit for 2-3 seconds. Then press back button.
  3. Now Notification Suggestion Dialog will be shown.

Screenshot_2024-06-26-07-22-02-77_b72a20be883aec8a014bd2b7c7038e87

Screenshot_2024-06-26-07-21-39-29_b72a20be883aec8a014bd2b7c7038e87

Error logs

No logs.

Solution

It should work as intended.

Additional context

No additional context.

Device Environment

Realme 7 Pro.

Android 12 (Realme UI 3.0).

Acknowledgements

inotia00 commented 3 days ago

In Reddit 2024.26.1+, obfuscation is applied to most classes, so there are cases where the patch is not applied even if the patch is successful.

The workaround is to roll back to Reddit 2024.25.3, a version that does not have obfuscation applied to the class.

Aryan-Chauhan commented 3 days ago

New information: Till yesterday I was using v2024.25.3 and this feature wasn't working in it, either.

I added this info in application description.

inotia00 commented 2 days ago

It may have been fixed by https://github.com/inotia00/revanced-integrations/commit/eebd225262d4fb141d6202bebc6d2e6f9f1f7987