inotia00 / ReVanced_Extended

ReVanced Extended Issues/Request repo
725 stars 29 forks source link

bug(YouTube/Settings) : In RVX Settings, `header text` & `back button` are not side-by-side. #2201

Closed Aryan-Chauhan closed 4 months ago

Aryan-Chauhan commented 4 months ago

Type

Cosmetic

Tools used

Revancify

Application

YT v19.23.40

Latest dev patches & dev integrations, as of today.

Bug description

In RVX Settings, header text and back button are not side-by-side. In other words, they are not in alignment with reference to each other's position.

Few months ago, this bug didn't existed. I think it happened after the re-organization of settings took place (or maybe not).

The misalignment is same for the sub-menus like Ads, Feed, General, Player, etc.

Screenshot_2024-06-28-09-31-32-01_a9acfd2263b6b7a65bf2540b0d9449ca

Screenshot_2024-06-28-09-45-32-74_a9acfd2263b6b7a65bf2540b0d9449ca.jpg

Screenshot_2024-06-28-09-45-40-68_a9acfd2263b6b7a65bf2540b0d9449ca.jpg

Error logs

No logs.

Solution

Both of them should be side-by-side, just like so many other Android apps.

Additional context

No additional context.

Device Environment

Realme 7 Pro.

Android 12 (Realme UI 3.0).

Acknowledgements

inotia00 commented 4 months ago

It does not reproduce on my side

Doesn't the issue reproduce when you turn off the pre-releases setting and patch again? (Instead of installing the patched app, patch it again)

Aryan-Chauhan commented 4 months ago

Still the same.

Screenshot_2024-06-28-16-50-13-73_d11ae654701a5fadb313ea6fa9a6836f.jpg

Screenshot_2024-06-28-16-50-29-53_d11ae654701a5fadb313ea6fa9a6836f.jpg

inotia00 commented 4 months ago

If so, this is probably not a bug that originated in the latest release

It appears to be a bug that has been around for quite some time, or a bug related to system fonts

ILoveOpenSourceApplications commented 4 months ago

How is it inside YouTube's General setting?

sr-shishir commented 4 months ago

Still the same.

Screenshot_2024-06-28-16-50-13-73_d11ae654701a5fadb313ea6fa9a6836f.jpg

Screenshot_2024-06-28-16-50-29-53_d11ae654701a5fadb313ea6fa9a6836f.jpg

I think it's not a bug. I checked official YouTube settings UI, there also a slight up & down between these two signs.

inotia00 commented 4 months ago

It may have been fixed by https://github.com/inotia00/revanced-integrations/commit/f36f3b0900dcf6e1e2f729023272410812442cbf

Aryan-Chauhan commented 4 months ago

How is it inside YouTube's General setting?

Not perfect, but better than RVX.

Screenshot_2024-06-28-21-30-40-41_a9acfd2263b6b7a65bf2540b0d9449ca.jpg

Aryan-Chauhan commented 4 months ago

Still the same.

Screenshot_2024-06-28-16-50-13-73_d11ae654701a5fadb313ea6fa9a6836f.jpg

Screenshot_2024-06-28-16-50-29-53_d11ae654701a5fadb313ea6fa9a6836f.jpg

I think it's not a bug. I checked official YouTube settings UI, there also a slight up & down between these two signs.

Yes, slight.

But in RVX Settings, it's much more noticeable.

Aryan-Chauhan commented 4 months ago

No difference on my side.

Screenshot_2024-06-28-21-43-51-65_a9acfd2263b6b7a65bf2540b0d9449ca.jpg

Francesco146 commented 4 months ago

https://github.com/inotia00/revanced-patches/commit/ab2db2b8b88337ded3ea43e91600819fab5e48f1

this might be the cause

Francesco146 commented 4 months ago

@Aryan-Chauhan test the latest stable Release of RVX, should work as expected.

Aryan-Chauhan commented 4 months ago

@Aryan-Chauhan test the latest stable Release of RVX, should work as expected.

I already tried v4.9.2 and it is the same.

I've shown screenshot of v4.9.2 above.

Francesco146 commented 4 months ago

mmh, then the code you are running works fine on my phone, might be a font style issue

inotia00 commented 4 months ago

Yeah.. There haven't been any changes to the toolbar side of RVX settings in recent months

It was an issue that could not be reproduced even though I tested it on 3 devices (can't be fixed on the RVX side)

Closing issue