inotia00 / ReVanced_Extended

ReVanced Extended Issues/Request repo
697 stars 21 forks source link

bug(YouTube/Disable force auto captions): patch doesn't work with Shorts #2346

Closed federicogith closed 1 week ago

federicogith commented 2 weeks ago

Type

Error while patching

Tools used

RVX Manager

Application

YouTube v19.16.39 Patches latest dev release

Bug description

Explained in the title.

Error logs

No response

Solution

No response

Additional context

No response

Device Environment

No response

Acknowledgements

inotia00 commented 2 weeks ago

Please attach an example of a shorts video with forced auto captions applied

federicogith commented 2 weeks ago

Please attach an example of a shorts video with forced auto captions applied

The bug seems to arise only with Shorts in the subscriptions feed AND with certain system languages, I only tried Italian

inotia00 commented 2 weeks ago

There is an issue when applying patches in Shorts: https://github.com/inotia00/ReVanced_Extended/issues/484

To prevent this, patches are not applied to Shorts

Since this old bug cannot be fixed, the following description will be added to the settings:

Limitation: This setting does not apply to Shorts
inotia00 commented 1 week ago

nvm I refactored the patch so it now works properly in Shorts too

inotia00 commented 1 week ago

reflected in revanced-patches-4.13.1