inotia00 / ReVanced_Extended

ReVanced Extended Issues/Request repo
739 stars 29 forks source link

suggestion: Ability to toggle multiple options in `Hide settings menu` patch without being prompted to restart client each time #2423

Open Rairof opened 1 month ago

Rairof commented 1 month ago

Application

YouTube

Suggestion description

For convenience, it would be better to let users select multiple options inside Hide settings menu category instead of having a prompt to restart client each time a toggle is changed.

My suggestion- The pop up only appears after we toggle the required options and go back (press the back button or icon on top left) or click on "done" button on top right or something similar. Screenshot_20241007-030402_YouTube Screenshot_20241007-030749_YouTube Music

Acknowledgements

GucekPL commented 1 month ago

But you can click ‘cancel’ or the area outside the dialogand only click ‘OK’ after selecting the last option you are interested in

Rairof commented 1 month ago

https://github.com/inotia00/ReVanced_Extended/issues/2423#issuecomment-2397868302 It works but it's annoying and inconvenient to do it for each and every toggle change. It would be better if the pop up only appears after we toggled the required options and go back (press the back button/icon on top left) or click on "done" button on top right or something similar.

federicogith commented 1 month ago

One solution could be to have another option at the top that hides all the settings menus just like the "Hide quick actions container" option does with quick actions Screenshot_20241026_163411_YouTube

Rairof commented 1 month ago

https://github.com/inotia00/ReVanced_Extended/issues/2423#issuecomment-2439625789 It's best to have individual options for each settings option to preserve the liberty of user's preferences on toggling whatever options they want.

federicogith commented 1 month ago

It's best to have individual options for each settings option to preserve the liberty of user's preferences on toggling whatever options they want.

What? Who said anything about removing the individual options 🫠 Just suggested to add an extra option at top that when enabled it hides all the setting menus When it's disabled you can still choose which one to hide or see individually just like the screen above

Rairof commented 1 month ago

https://github.com/inotia00/ReVanced_Extended/issues/2423#issuecomment-2439760225 Having an option that hides all the setting menus isn't a solution to the proposed issue i.e the frequent restart pop ups. It's best to just remove the restart pop up and promt it only when user triggers back gesture or clicks on the back button or have a "save" button to select after selecting relevant settings to hide then showing the restart pop up frequently after each toggle change.