search

inotia00 / ReVanced_Extended

ReVanced Extended Issues/Request repo
714 stars 29 forks source link

bug(YouTube/Hide ads): `Hide view products banner` setting not working #2437

Open smed79 opened 3 days ago

smed79 commented 3 days ago

Type

Tools used

Application

Bug description

View products banner that overly the video player is not hidden.

hvpd

bnr

Additional context

Example video when you can reproduce

Device Environment

RVX Logs

- Device Info
RVX Manager: 1.22.2
Model: CPH2581
Android version: 14 (OxygenOS)
Supported architectures: arm64-v8a, armeabi-v7a, armeabi
Root permissions: No

- Patch Info
App: rvx.android.youtube v19.16.39 (Suggested: Any)
Patches version: v4.14.2
Patches added: Custom header for YouTube, Force hide player buttons background, Hide Shorts dimming, Hide shortcuts, MaterialYou
Patches removed: None
Default patch options changed: None

- Settings
Allow changing patch selection: true
Version compatibility check: true
Show universal patches: false
Remove unused library: true
Use pre-release: false
Patches source: inotia00/revanced-patches
Integration source: inotia00/revanced-integrations

- Logs
Reading APK
Decoding app manifest
Loading patches
Merging integrations
Deleting existing temporary files directory
Decoding resources
Executing patches
Applied 61 patches
Compiling patched dex files
Compiled 8 dex files
Compiling modified resources
Ripping selected native libs
Aligning APK
Signing APK
Patched APK
Installing patched app
Installed

Acknowledgements

inotia00 commented 3 days ago

please add the version of revanced-patches you used

smed79 commented 3 days ago

More details add above ā˜ļø

I get more big annoying banner on the below šŸ‘‡ video

Screenshots

001

002

Thank you in advance šŸ™

smed79 commented 1 day ago

Applying the last patches v4.15.1-dev.3 unfortunately did not fixed the issue.

What i can provide to help you investigate?

PS: I also noticed that "Up next" suggested video banner is not hidden with "Hide end screen card and suggested video" switched on (autoplay is off).

Should i open new issue for this bug or just follow tracking it here?

inotia00 commented 1 day ago

PS: I also noticed that "Up next" suggested video banner is not hidden with "Hide end screen card and suggested video" switched on (autoplay is off).

This is autoplay preview container, not end screen card and suggested video

ā–¼ autoplay preview container ā–¼

hide-autoplay-preview

inotia00 commented 1 day ago

What i can provide to help you investigate?

If it's not hidden even in the latest dev branch, then this is a new ad that is not being reproduced on my side.

You can extract the debug log by following the steps below:

  1. Install ADB on your PC according to the docs.
  2. Turn on Enable debug logging and Enable dubug buffer logging in RVX settings.
  3. Enable USB debugging in Developer options in System settings.
  4. Connect your phone and PC, and open CMD in the directory where adb.exe is.
  5. Type the following in CMD:
adb logcat | findstr "LithoFilterPatch" > log.txt
  1. Open a video with the view products banner.
  2. Type Ctrl + C in CMD.
  3. Attach the log.txt.
smed79 commented 1 day ago

You can extract the debug log by following the steps below

I'm on Linux, so I used grep instead of findstr but unfortunately i get an empty file.

logcat

Filtering the logcat by the package name

adb logcat | grep rvx.android.youtube > log.txt

give me the output > 64f628f5af0dd2e64339d34d0d99d580

This is autoplay preview container, not end screen card and suggested video

Thank you very much :pray:

inotia00 commented 19 hours ago

No debug logging included

Are these turned on?

2. Turn on Enable debug logging and Enable dubug buffer logging in RVX settings.

Command in Linux:

adb logcat | grep --line-buffered "LithoFilterPatch" > log.txt
smed79 commented 13 hours ago

Of course yes, Enable debug logging and Enable dubug buffer logging in RVX settings are turned on and also USB debugging in Developer Options but i still get an empty log.txt file with the command you have provided for linux.

I also tried via Wireless debugging using Shizuku + aShell You > Same thing, i get an empty file.

I don't know, maybe something goes wrong with my rom/device. I will try to find another device for testing and see if i can reproduce the ads, then providing a log.

Thank you so much for your assistance.

inotia00 commented 12 hours ago

You can also extract logs via the Locat Reader app

Try this:

  1. Download and install the Locat Reader app:

F-Droid (summary) F-Droid (direct download)

  1. Enable USB debugging and grant permission by entering the following command from the CMD on your PC:
adb shell "pm grant com.dp.logcatapp android.permission.READ_LOGS && am force-stop com.dp.logcatapp"

  1. Launch the Locat Reader app

  2. Move to 3dot menu - Filters

  3. Click the + button and type it like a screenshot:

LogCatReader

and then, click OK

  1. In RVX, turn on the following settings:

    Settings - ReVanced Extended - Miscellaneous - Enable debug logging / Enable dubug buffer logging

  2. Force close and launch the RVX again

  3. Open a video with the view products banner

  4. After about 10 seconds, back to the Locat Reader app and click 3dot menu - Save

3Dots

  1. Attach the log.txt
smed79 commented 11 hours ago

Hope this help > logcat_10-20-2024_08-28-01.txt.zip

... & Thanks for the useful tutorial :+1:

inotia00 commented 11 hours ago

Hope this help > logcat_10-20-2024_08-28-01.txt.zip

... & Thanks for the useful tutorial šŸ‘

The debug log contains the keyword shopping_overlay.eml-js-b, which is missing from both ReVanced and RVX

Can you please add the keyword shopping_overlay to Settings - ReVanced Extended - General - Custom filter - Custom filter and report back if it gets hidden?

smed79 commented 10 hours ago

I confirm... Yes.

The added filter: shopping_overlay, successfully hide the shopping products banner :tada: