bug(Reddit): `Change version code` patch doesn't work as it's set to false

inotia00 / ReVanced_Extended

ReVanced Extended Issues/Request repo

737 stars 29 forks source link

bug(Reddit): `Change version code` patch doesn't work as it's set to false #2486

Closed rywz closed 2 weeks ago

rywz commented 2 weeks ago

Type

Error while patching

Tools used

rvx-builder

Application

Reddit 2024.46.0.2012189

Bug description

Self explanatory. It sets ChangeVersionCode to false and the patch doesn't work as intended.

Acknowledgements

[X] This issue does not reproduce on unpatched YouTube or YT Music.
[X] This issue is not a duplicate of an existing bug report.
[X] I didn't use any settings marked as Experimental Flags.
[X] I have chosen an appropriate title.
[X] All requested information has been provided properly.
[X] I have written the title and contents in English.

inotia00 commented 2 weeks ago

The arsclib branch is based on a fairly old revanced patcher, so sometimes patches are not excluded

Therefore, the Change version code patch only changes the version code if the value of options.json is true

You left the value of options.json false or did not change it, so the patch was not applied

This is the intended behavior

rywz commented 2 weeks ago

You left the value of options.json false or did not change it, so the patch was not applied

How do I change options.json tho?

inotia00 commented 2 weeks ago

If you are using termux, type opon

options.json editor will open

KobeW50 commented 2 weeks ago

If you are using termux, type opon

options.json editor will open

I would like to add this tip to the documentation, but I am having trouble saving and exiting from the editor. How does one save and exit after making changes to the options.json?

rywz commented 2 weeks ago

If you are using termux, type opon

options.json editor will open

I would like to add this tip to the documentation, but I am having trouble saving and exiting from the editor. How does one save and exit after making changes to the options.json?

You need to patch first. After that enter options.js and you'll see the values. Change it according to your needs, CTRL + X & say Yes, then confirm the changes by clicking the enter button.