inotia00 / ReVanced_Extended

ReVanced Extended Issues/Request repo
697 stars 21 forks source link

Bug: Unintended snackbar is popping up #853

Closed sleepingiv closed 1 year ago

sleepingiv commented 1 year ago

Type

Error at runtime

Application

YouTube 18.15.40 Patches v2.169.5

Bug description

"reload video to vote using ReturnYouTubeDislike" snackbar is popping up when adding or removing a playlist from library.

Steps to reproduce

Variant: nonRoot Arch: arm64-v8a App: YouTube-18-15-40.apk CLI: inotia00-cli-v2.21.0.jar Patches: inotia00-patches-v2.169.5.jar Integrations: inotia00-integrations-v0.102.6.apk Patches argument: -i custom-branding-icon-mmt -i custom-branding-name -i custom-seekbar-color -i custom-video-speed -i default-video-quality -i default-video-speed -i disable-startup-shorts-player -i enable-minimized-playback -i enable-old-quality-layout -i enable-open-links-directly -i enable-seekbar-tapping -i enable-timestamps-speed -i hide-auto-captions -i hide-autoplay-button -i hide-button-container -i hide-captions-button -i hide-cast-button -i hide-channel-avatar-section -i hide-channel-watermark -i hide-create-button -i hide-crowdfunding-box -i hide-endscreen-overlay -i hide-filmstrip-overlay -i hide-floating-microphone -i hide-flyout-panel -i hide-general-ads -i hide-info-cards -i hide-mix-playlists -i hide-pip-notification -i hide-player-overlay-filter -i hide-previous-next-button -i hide-search-terms -i hide-shorts-button -i hide-shorts-component -i hide-shorts-navbar -i hide-stories -i hide-suggested-actions -i hide-tooltip-content -i hide-video-ads -i lift-vertical-video-restriction -i materialyou -i microg-support -i optimize-resource -i overlay-buttons -i patch-options -i protobuf-spoof -i return-youtube-dislike -i sponsorblock -i swipe-controls -i theme

Relevant log output

INFO: Reading dex files 
INFO: Loading resource table... 
INFO: Decoding AndroidManifest.xml only, because resources are not needed 
INFO: Loading resource table from file: revanced-cache/1.apk 
INFO: Skipping bypass-ambient-mode-restrictions: Excluded by default 
INFO: Skipping change-homepage: Excluded by default 
INFO: Skipping client-spoof: Excluded by default 
INFO: Skipping custom-branding-icon-afn-blue: Excluded by default 
INFO: Skipping custom-branding-icon-afn-red: Excluded by default 
INFO: Skipping custom-branding-icon-revancify: Excluded by default 
INFO: Skipping disable-haptic-feedback: Excluded by default 
INFO: Skipping disable-landscape-mode: Excluded by default 
INFO: Skipping disable-quic-protocol: Excluded by default 
INFO: Skipping enable-external-browser: Excluded by default 
INFO: Skipping enable-old-layout: Excluded by default 
INFO: Skipping enable-tablet-miniplayer: Excluded by default 
INFO: Skipping enable-tablet-navigation-bar: Excluded by default 
INFO: Skipping enable-wide-searchbar: Excluded by default 
INFO: Skipping force-hide-player-button-background: Excluded by default 
INFO: Skipping force-premium-heading: Excluded by default 
INFO: Skipping force-vp9-codec: Excluded by default 
INFO: Skipping header-switch: Excluded by default 
INFO: Skipping hide-account-menu: Excluded by default 
INFO: Skipping hide-auto-player-popup-panels: Excluded by default 
INFO: Skipping hide-autoplay-preview: Excluded by default 
INFO: Skipping hide-category-bar: Excluded by default 
INFO: Skipping hide-collapse-button: Excluded by default 
INFO: Skipping hide-comment-component: Excluded by default 
INFO: Skipping hide-double-tap-overlay-filter: Excluded by default 
INFO: Skipping hide-email-address: Excluded by default 
INFO: Skipping hide-endscreen-cards: Excluded by default 
INFO: Skipping hide-fullscreen-panels: Excluded by default 
INFO: Skipping hide-home-button: Excluded by default 
INFO: Skipping hide-music-button: Excluded by default 
INFO: Skipping hide-player-button-background: Excluded by default 
INFO: Skipping hide-quick-actions: Excluded by default 
INFO: Skipping hide-seekbar: Excluded by default 
INFO: Skipping hide-snackbar: Excluded by default 
INFO: Skipping hide-subscriptions-button: Excluded by default 
INFO: Skipping hide-time-stamp: Excluded by default 
INFO: Skipping layout-switch: Excluded by default 
INFO: Skipping switch-create-notification: Excluded by default 
INFO: Skipping translations: Excluded by default 
INFO: Merging inotia00-integrations-v0.102.6.apk 
INFO: Loading resource table... 
INFO: Deleting existing resource cache directory 
INFO: Decoding resources 
INFO: Decoding AndroidManifest.xml with resources... 
INFO: Loading resource table from file: revanced-cache/1.apk 
INFO: Regular manifest package... 
INFO: Decoding file-resources... 
INFO: Decoding values */* XMLs... 
INFO: custom-branding-icon-mmt succeeded 
INFO: custom-branding-name succeeded 
INFO: custom-seekbar-color succeeded 
INFO: custom-video-speed succeeded 
INFO: default-video-quality succeeded 
INFO: default-video-speed succeeded 
INFO: disable-startup-shorts-player succeeded 
INFO: enable-minimized-playback succeeded 
INFO: enable-old-quality-layout succeeded 
INFO: enable-open-links-directly succeeded 
INFO: enable-seekbar-tapping succeeded 
INFO: enable-timestamps-speed succeeded 
INFO: hide-auto-captions succeeded 
INFO: hide-autoplay-button succeeded 
INFO: hide-button-container succeeded 
INFO: hide-captions-button succeeded 
INFO: hide-cast-button succeeded 
INFO: hide-channel-avatar-section succeeded 
INFO: hide-channel-watermark succeeded 
INFO: hide-create-button succeeded 
INFO: hide-crowdfunding-box succeeded 
INFO: hide-endscreen-overlay succeeded 
INFO: hide-filmstrip-overlay succeeded 
INFO: hide-floating-microphone succeeded 
INFO: hide-flyout-panel succeeded 
INFO: hide-general-ads succeeded 
INFO: hide-info-cards succeeded 
INFO: hide-mix-playlists succeeded 
INFO: hide-pip-notification succeeded 
INFO: hide-player-overlay-filter succeeded 
INFO: hide-previous-next-button succeeded 
INFO: hide-search-terms succeeded 
INFO: hide-shorts-button succeeded 
INFO: hide-shorts-component succeeded 
INFO: hide-shorts-navbar succeeded 
INFO: hide-stories succeeded 
INFO: hide-suggested-actions succeeded 
INFO: hide-tooltip-content succeeded 
INFO: hide-video-ads succeeded 
INFO: lift-vertical-video-restriction succeeded 
INFO: materialyou succeeded 
INFO: microg-support succeeded 
INFO: optimize-resource succeeded 
INFO: overlay-buttons succeeded 
INFO: patch-options succeeded 
INFO: protobuf-spoof succeeded 
INFO: return-youtube-dislike succeeded 
INFO: sponsorblock succeeded 
INFO: swipe-controls succeeded 
INFO: theme succeeded 
INFO: Compiling resources 
INFO: Writing modified dex files 
INFO: Aligning YouTube-18-15-40.apk to YouTube-Revanced-18-15-40_aligned.apk 
INFO: Signing YouTube-Revanced-18-15-40_aligned.apk to YouTube-Revanced-18-15-40_signed.apk 
INFO: Found existing keystore: revanced.keystore 
INFO: Copying YouTube-Revanced-18-15-40_signed.apk to YouTube-Revanced-18-15-40.apk 
INFO: Cleaned up cache directory 
INFO: Finished

Screenshots or videos

https://user-images.githubusercontent.com/64865031/234504822-bc20ab35-1fc4-4301-895a-1592d45a2e22.mp4

Solution

No response

Additional context

No response

Device Environment

Android 13 , MIUI 14

Acknowledgements

inotia00 commented 1 year ago

This toast message is shown when ReturnYouTubeDislike fails to submit voting for a specific reason.

Since the output of this toast message is within the intended range, I'm not treating this as a bug.

sleepingiv commented 1 year ago

But I am just adding or removing a playlist from library , here the RYD shouldn't be triggered.

inotia00 commented 1 year ago

Vote submissions happen in the background, whether or not the video is playing.